Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of remove dynamic params #289

Merged
merged 48 commits into from
May 1, 2020
Merged

Review of remove dynamic params #289

merged 48 commits into from
May 1, 2020

Conversation

DarqueWarrior
Copy link
Collaborator

PR Summary

This is a major PR to merge the changes from the remove dynamic parameters.

PR Checklist

James O'Neill and others added 30 commits January 20, 2020 17:33
Add parameter classes
33fe74a
import classes via PSD1, add exportFunctions list
95860f6
Replace dynamic parameters with clasess
a265bc7
Move _Supports* functionality into calling fn
a42840a
remove _isonwindows
da9245e
remove _applyTypes
2beaa35
fix break of Add-VSteamWorkItem, improve build
978e0cc
@jhoneill
Merge remote-tracking branch 'upstream/master'
1fd09ed
@jhoneill
Use Invoke-VSTeamRequest externally and make _callApi Private again
c27dc5f
Auto-update of md help with 6.4.4 changes
688bdf4
Allow $env:testing to bypass validation checks
e2bb372
fix issue Getting build artifacts with no properties field
3467ddd
@jhoneill
Fix regressions and modify mocking in tests to work with new classes
427114f
@jhoneill
ensure validator doesn't break tests fix a couple more regressions & …
d1bc72f 
…mocks
@jhoneill
Merge remote-tracking branch 'upstream/master'
99871e2
@jhoneill
Merge remote-tracking branch 'upstream/master'
7af8dab
Tidy class loading - Merge classes to PSM1 file.
2fab630
@jhoneill
Merge remote-tracking branch 'upstream/master'
51d9b49
fix ProcessCompleter
9d53c00
fix ProcessCompleter
e990b83
@jhoneill
Merge branch 'master' of https://github.com/jhoneill/vsteam
80fcb5f
@jhoneill
Fixed tests to not mix source & built files.
2608b10
@jhoneill
Re-introduced a mockable to help one test (CI has 3 param not founds …
fed84c4 
…errors I can't repro)
@jhoneill
Fix build when file encodings are mixed
abdb3a1
@jhoneill
Merge remote-tracking branch 'upstream/master'
2dea841
@DarqueWarrior
Updated all the unit tests.
54c2006
@DarqueWarrior
Initial pass
2f10c8c
@DarqueWarrior
Added tests for ValidateProjectAttribute
7f96819
@DarqueWarrior
All tests passing again.
a26636b
@DarqueWarrior
Fixed file casing.
3a97ced
@SebastianSchuetze
Copy link
Collaborator

@DarqueWarrior I merged a PR that I finished (#283). This is using still the old way. If you think it is easy for you to also change the one cmdlet, then it would be perfect.
Otherwise, we need to write documentation anyways and I can do this later.

@SebastianSchuetze SebastianSchuetze mentioned this pull request Apr 28, 2020
Closed
@DarqueWarrior
Copy link
Collaborator Author

This is looking really good and I hope to merge soon.

@DarqueWarrior DarqueWarrior merged commit 829d682 into master May 1, 2020
@DarqueWarrior DarqueWarrior deleted the review branch May 1, 2020 18:21
This was referenced May 2, 2020
Closed
Closed
@jhoneill jhoneill mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarqueWarrior @SebastianSchuetze @jhoneill