Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: memote annotation and consistency scoring #8

Merged
merged 43 commits into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
85302bc
feat: example on how to integrate some tests from Memote #3
famosab Nov 2, 2022
22e00be
feat: memote integration, reqs update
famosab Nov 2, 2022
a20ac1a
feat: memote, make errors available
famosab Nov 4, 2022
4dcc451
feat: restructure memote as valid return
famosab Nov 4, 2022
0e238cc
feat: store memote score for annotation and consistency
mihai-sysbio Mar 6, 2023
03e0ed0
fix: handle job matrix as workflow output
mihai-sysbio Mar 6, 2023
861ea55
fix: typo
mihai-sysbio Mar 6, 2023
fb78a76
fix: matrix format for workflow strategy
mihai-sysbio Mar 6, 2023
9581d5b
chore: update gh workflow dependency
mihai-sysbio Mar 6, 2023
ddaa638
fix: graphql releases sorted by most recent
mihai-sysbio Mar 6, 2023
7b7a994
update validation results for SysBioChalmers/yeast-GEM
mihai-sysbio Mar 6, 2023
7b75d12
fix: use right var in workflow results
mihai-sysbio Mar 6, 2023
ff2b264
update validation results for SysBioChalmers/Human-GEM
mihai-sysbio Mar 6, 2023
641e194
update validation results for SysBioChalmers/Fruitfly-GEM
mihai-sysbio Mar 6, 2023
c27ee5a
feat: use Docker image of Memote
mihai-sysbio Mar 6, 2023
cafbbff
feat: use custom Docker image of Memote
mihai-sysbio Mar 6, 2023
116dcaf
fix: pass gh token to container
mihai-sysbio Mar 6, 2023
b40e693
chore: cleanup
mihai-sysbio Mar 8, 2023
32d0441
chore: remove duplicate file
mihai-sysbio Mar 8, 2023
0f90cbc
fix: check file exists and size
mihai-sysbio Mar 13, 2023
aefb80d
fix: memote params
mihai-sysbio Mar 13, 2023
5b7bcda
refactor: split cobra load
mihai-sysbio Mar 14, 2023
ac2a9ab
fix: check if requests succeed
mihai-sysbio Mar 14, 2023
be22f8e
fix: memote test listing
mihai-sysbio Mar 14, 2023
d8059e3
Merge pull request #9 from MetabolicAtlas/feat/memote-docker
mihai-sysbio Mar 14, 2023
e3e38b6
update index of standard-GEMs
mihai-sysbio Mar 14, 2023
f6d4006
update validation results for SysBioChalmers/yeast-GEM
mihai-sysbio Mar 14, 2023
ee7ddd6
update validation results for SysBioChalmers/Human-GEM
mihai-sysbio Mar 14, 2023
a419706
update validation results for SysBioChalmers/Fruitfly-GEM
mihai-sysbio Mar 14, 2023
a6e0183
update validation results for SysBioChalmers/Mouse-GEM
mihai-sysbio Mar 14, 2023
f1c81ae
update validation results for SysBioChalmers/Sco-GEM
mihai-sysbio Mar 14, 2023
34aebe6
update validation results for SysBioChalmers/Zebrafish-GEM
mihai-sysbio Mar 14, 2023
f488dcd
update validation results for SysBioChalmers/Worm-GEM
mihai-sysbio Mar 14, 2023
7250cf5
update validation results for haowang-bioinfo/Ecoli-GEM
mihai-sysbio Mar 14, 2023
3639eb1
update validation results for tibbdc/vna-GEM
mihai-sysbio Mar 14, 2023
fbf2fdb
update validation results for SysBioChalmers/Rat-GEM
mihai-sysbio Mar 14, 2023
df58b80
chore: increate number of validated releases
mihai-sysbio Mar 15, 2023
99e0c09
update validation results for SysBioChalmers/yeast-GEM
mihai-sysbio Mar 15, 2023
3e6eb16
update validation results for SysBioChalmers/Human-GEM
mihai-sysbio Mar 15, 2023
a53adf6
update validation results for SysBioChalmers/Fruitfly-GEM
mihai-sysbio Mar 15, 2023
59c65f7
update validation results for SysBioChalmers/Sco-GEM
mihai-sysbio Mar 15, 2023
cc4192c
update validation results for SysBioChalmers/Zebrafish-GEM
mihai-sysbio Mar 15, 2023
135945b
update validation results for SysBioChalmers/Mouse-GEM
mihai-sysbio Mar 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 31 additions & 33 deletions .github/workflows/validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ on:
jobs:
setup:
runs-on: ubuntu-latest
container:
image: ghcr.io/metabolicatlas/memote-docker:0.13
volumes:
- ${{ github.workspace }}:/project:rw
options: --user root --workdir /project
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
env:
Expand All @@ -19,33 +24,39 @@ jobs:
with:
fetch-depth: 1

- name: Set up Python 3
uses: actions/setup-python@v4
with:
python-version: "3.x"

- name: Install dependencies
run: pip install -r requirements.txt

- id: set-matrix
run: echo "::set-output name=matrix::$(python -c 'import runner; runner.matrix()')"
- name: Fetch list of repositories
run: |
git config --global --add safe.directory /__w/standard-GEM-validation/standard-GEM-validation
python -c 'import runner; runner.matrix()'

- name: Cache pip directory
uses: actions/cache@v3
id: cache
- name: Commit index of standard-GEMs
uses: stefanzweifel/git-auto-commit-action@v4
with:
path: ~/.cache/pip
key: ${{ github.sha }}
commit_user_name: validation-bot
commit_message: update index of standard-GEMs
file_pattern: index.json
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Define job matrix from index
id: set-matrix
run: echo "matrix=$(cat index.json)" >> $GITHUB_OUTPUT

validate:
needs: setup
runs-on: ubuntu-latest
container:
image: ghcr.io/metabolicatlas/memote-docker:0.13
volumes:
- ${{ github.workspace }}:/project:rw
options: --user root --workdir /project
continue-on-error: true
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
strategy:
fail-fast: false
matrix: ${{fromJson(needs.setup.outputs.matrix)}}
matrix:
gem: ${{ fromJSON(needs.setup.outputs.matrix) }}
max-parallel: 1

steps:
Expand All @@ -54,29 +65,16 @@ jobs:
with:
fetch-depth: 1

- name: Set up Python 3
uses: actions/setup-python@v4
with:
python-version: "3.x"

- name: Restore pip cache directory
uses: actions/cache@v3
id: cache
with:
path: ~/.cache/pip
key: ${{ github.sha }}

- name: Install dependencies
run: pip install -r requirements.txt

- name: Validate repository
run: python -c 'import runner; runner.validate("${{ matrix.gem }}")'
run: |
git config --global --add safe.directory /__w/standard-GEM-validation/standard-GEM-validation
python -c 'import runner; runner.validate("${{ matrix.gem }}")'

- name: Update branch
run: git pull --ff

- name: Auto-commit results
uses: stefanzweifel/git-auto-commit-action@v4.4.0
uses: stefanzweifel/git-auto-commit-action@v4
with:
commit_user_name: validation-bot
commit_message: update validation results for ${{ matrix.gem }}
Expand Down
1 change: 1 addition & 0 deletions index.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
["SysBioChalmers/yeast-GEM", "SysBioChalmers/Human-GEM", "SysBioChalmers/Fruitfly-GEM", "SysBioChalmers/Mouse-GEM", "SysBioChalmers/Sco-GEM", "SysBioChalmers/Zebrafish-GEM", "iAMB-RWTH-Aachen/Opol-GSMM", "SysBioChalmers/Worm-GEM", "haowang-bioinfo/Ecoli-GEM", "tibbdc/vna-GEM", "SysBioChalmers/Rat-GEM"]
4 changes: 0 additions & 4 deletions requirements.txt

This file was deleted.

137 changes: 123 additions & 14 deletions results/SysBioChalmers_Fruitfly-GEM.json

Large diffs are not rendered by default.

235 changes: 160 additions & 75 deletions results/SysBioChalmers_Human-GEM.json
Original file line number Diff line number Diff line change
@@ -1,121 +1,206 @@
{
"SysBioChalmers/Human-GEM": [
{
"v0.5.2": {
"v1.14.0": {
"standard-GEM": [
{
"0.4": false
"0.4": true
},
{
"test_results": {}
"test_results": {
"cobrapy-load-json": {
"0.26.2": false,
"errors": "\"[Errno 2] No such file or directory: 'Human-GEM.json'\""
},
"cobrapy-load-matlab": {
"0.26.2": false,
"errors": "\"Error -3 while decompressing data: incorrect header check\""
},
"cobrapy-load-sbml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-load-yaml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-validate-sbml": {
"0.26.2": false,
"errors": "\"{'SBML_FATAL': [], 'SBML_ERROR': [], 'SBML_SCHEMA_ERROR': [], 'SBML_WARNING': ['E0 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n', 'E1 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n'], 'COBRA_FATAL': [], 'COBRA_ERROR': [], 'COBRA_WARNING': [], 'COBRA_CHECK': []}\""
},
"memote-score": {
"0.13.0": 0.4740305818784403,
"errors": ""
},
"yamllint": {
"1.29.0": true,
"errors": []
}
}
}
]
}
},
{
"v0.5.1": {
"v1.13.0": {
"standard-GEM": [
{
"0.4": false
"0.4": true
},
{
"test_results": {}
"test_results": {
"cobrapy-load-json": {
"0.26.2": false,
"errors": "\"[Errno 2] No such file or directory: 'Human-GEM.json'\""
},
"cobrapy-load-matlab": {
"0.26.2": false,
"errors": "\"Error -3 while decompressing data: incorrect header check\""
},
"cobrapy-load-sbml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-load-yaml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-validate-sbml": {
"0.26.2": false,
"errors": "\"{'SBML_FATAL': [], 'SBML_ERROR': [], 'SBML_SCHEMA_ERROR': [], 'SBML_WARNING': ['E0 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n', 'E1 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n'], 'COBRA_FATAL': [], 'COBRA_ERROR': [], 'COBRA_WARNING': [], 'COBRA_CHECK': []}\""
},
"memote-score": {
"0.13.0": 0.47403057916252217,
"errors": ""
},
"yamllint": {
"1.29.0": true,
"errors": []
}
}
}
]
}
},
{
"v0.5.0": {
"v1.12.0": {
"standard-GEM": [
{
"0.4": false
"0.4": true
},
{
"test_results": {}
"test_results": {
"cobrapy-load-json": {
"0.26.2": false,
"errors": "\"[Errno 2] No such file or directory: 'Human-GEM.json'\""
},
"cobrapy-load-matlab": {
"0.26.2": false,
"errors": "\"Error -3 while decompressing data: incorrect header check\""
},
"cobrapy-load-sbml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-load-yaml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-validate-sbml": {
"0.26.2": false,
"errors": "\"{'SBML_FATAL': [], 'SBML_ERROR': [], 'SBML_SCHEMA_ERROR': [], 'SBML_WARNING': ['E0 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n', 'E1 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n'], 'COBRA_FATAL': [], 'COBRA_ERROR': [], 'COBRA_WARNING': [], 'COBRA_CHECK': []}\""
},
"memote-score": {
"0.13.0": 0.47564756532249464,
"errors": ""
},
"yamllint": {
"1.29.0": true,
"errors": []
}
}
}
]
}
},
{
"v0.4.2": {
"v1.11.0": {
"standard-GEM": [
{
"0.4": false
"0.4": true
},
{
"test_results": {}
"test_results": {
"cobrapy-load-json": {
"0.26.2": false,
"errors": "\"[Errno 2] No such file or directory: 'Human-GEM.json'\""
},
"cobrapy-load-matlab": {
"0.26.2": false,
"errors": "\"Error -3 while decompressing data: incorrect header check\""
},
"cobrapy-load-sbml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-load-yaml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-validate-sbml": {
"0.26.2": false,
"errors": "\"{'SBML_FATAL': [], 'SBML_ERROR': [], 'SBML_SCHEMA_ERROR': [], 'SBML_WARNING': ['E0 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n', 'E1 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n'], 'COBRA_FATAL': [], 'COBRA_ERROR': [], 'COBRA_WARNING': [], 'COBRA_CHECK': []}\""
},
"memote-score": {
"0.13.0": 0.4813329434104094,
"errors": ""
},
"yamllint": {
"1.29.0": true,
"errors": []
}
}
}
]
}
},
{
"v0.4.1": {
"v1.10.0": {
"standard-GEM": [
{
"0.4": false
"0.4": true
},
{
"test_results": {}
}
]
}
},
{
"v0.4.0": {
"standard-GEM": [
{
"0.4": false
},
{
"test_results": {}
}
]
}
},
{
"v0.3.1": {
"standard-GEM": [
{
"0.4": false
},
{
"test_results": {}
}
]
}
},
{
"v0.3.0": {
"standard-GEM": [
{
"0.4": false
},
{
"test_results": {}
}
]
}
},
{
"v0.2.0": {
"standard-GEM": [
{
"0.4": false
},
{
"test_results": {}
}
]
}
},
{
"v0.1.0": {
"standard-GEM": [
{
"0.4": false
},
{
"test_results": {}
"test_results": {
"cobrapy-load-json": {
"0.26.2": false,
"errors": "\"[Errno 2] No such file or directory: 'Human-GEM.json'\""
},
"cobrapy-load-matlab": {
"0.26.2": false,
"errors": "\"Error -3 while decompressing data: incorrect header check\""
},
"cobrapy-load-sbml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-load-yaml": {
"0.26.2": true,
"errors": ""
},
"cobrapy-validate-sbml": {
"0.26.2": false,
"errors": "\"{'SBML_FATAL': [], 'SBML_ERROR': [], 'SBML_SCHEMA_ERROR': [], 'SBML_WARNING': ['E0 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n', 'E1 (Warning): General SBML conformance (core, L3); RDF does not contain valid ModelHistory; LibSBML expected to read the annotation into a ModelHistory object. Unfortunately, some attributes were not present or correct and the resulting ModelHistory object will not correctly produce the annotation. This functionality will be improved in later versions of libSBML. \\\\nReference: L3V1 Section 6.3\\\\n An invalid ModelHistory element has been stored.\\\\n'], 'COBRA_FATAL': [], 'COBRA_ERROR': [], 'COBRA_WARNING': [], 'COBRA_CHECK': []}\""
},
"memote-score": {
"0.13.0": 0.48129904134791174,
"errors": ""
},
"yamllint": {
"1.29.0": true,
"errors": []
}
}
}
]
}
Expand Down
Loading