Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: memote annotation and consistency scoring #8

Merged
merged 43 commits into from
May 10, 2023
Merged

feat: memote annotation and consistency scoring #8

merged 43 commits into from
May 10, 2023

Conversation

mihai-sysbio
Copy link
Member

This PR aims to resolve the integration of Memote scoring of models discussed in #3.

@mihai-sysbio mihai-sysbio force-pushed the feat/memote branch 4 times, most recently from e3f590e to 986d0fc Compare March 6, 2023 17:35
@mihai-sysbio mihai-sysbio changed the title feat: memote feat: memote annotation and consistency scoring Mar 6, 2023
@mihai-sysbio mihai-sysbio marked this pull request as ready for review March 14, 2023 11:42
@mihai-sysbio
Copy link
Member Author

With this branch the integration of Memote is deemed sufficient; a reduced set of tests is explicitly used, and only the total score is kept, as storing the entire report would burden the repository.
A caveat: the maximum allowed duration for a GitHub job seems to be 6 hours, which means there is a limit to how many model releases can be tested on a public runner. A new issue has been created to resolve this #10 .

@mihai-sysbio mihai-sysbio mentioned this pull request Mar 21, 2023
Open
@mihai-sysbio
Copy link
Member Author

Due to the long running time, validation of some models could not be completed - this is now reported as a new issue #10. Instead. the validation results were cherry-picked from a different branch.
Also, the work in this PR has indicated that a revision of the MEMOTE tests might be desired, see #12.

@mihai-sysbio mihai-sysbio requested a review from edkerk March 21, 2023 13:10
@mihai-sysbio mihai-sysbio merged commit 70e4409 into develop May 10, 2023
@mihai-sysbio mihai-sysbio deleted the feat/memote branch May 10, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edkerk edkerk Awaiting requested review from edkerk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihai-sysbio @famosab