Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instances of collectibles to nfts #199

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Dec 13, 2022

This PR is to update collectibles to nfts.

Reference: MetaMask/metamask-extension#16889

Code for Abis and bytecode:

pragma solidity ^0.8.7;

import "@openzeppelin/[email protected]/token/ERC721/ERC721.sol";

contract MyToken is ERC721 {
    constructor() ERC721("NFT Token", "NFT") {}

    function safeMint(uint256 tokenId) public {
        _safeMint(msg.sender, tokenId);
    }
}

@NidhiKJha NidhiKJha requested a review from a team as a code owner December 13, 2022 13:37
src/index.html Outdated Show resolved Hide resolved
@NidhiKJha NidhiKJha requested review from mcmire and Gudahtt December 20, 2022 14:41
src/constants.json Outdated Show resolved Hide resolved
@NidhiKJha NidhiKJha force-pushed the collectibles-to-nft branch from 586eadb to 5422dc3 Compare February 7, 2023 06:24
@NidhiKJha NidhiKJha requested a review from Gudahtt February 7, 2023 06:24
@NidhiKJha NidhiKJha force-pushed the collectibles-to-nft branch from 5422dc3 to cf1822c Compare February 7, 2023 15:18
src/constants.json Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
@Gudahtt
Copy link
Member

Gudahtt commented Feb 9, 2023

In a recent PR, the source code for the old "Collectibles" contract was added to the repository (in the contracts directory). Could you replace that contract with the source code for the new one?

src/index.js Outdated Show resolved Hide resolved
@@ -1,25 +1,21 @@
// SPDX-License-Identifier: MIT
pragma solidity >=0.4.22 <0.9.0;

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tried compiling this in Remix but got an error about Strings already being declared. I don't quite understand why, but, it went away with I removed the @4.8.1 or added it to the other two imports. Perhaps they should all be using the same version of @openzeppelin/contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants