Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFTs : Replacing all the instances of collectibles to NFTs #16889

Closed
wants to merge 8 commits into from
Closed

NFTs : Replacing all the instances of collectibles to NFTs #16889

wants to merge 8 commits into from

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Dec 9, 2022 •
edited
Loading

We're moving from using the term "collectible" to always using "NFT". This PR updates the associated files and instances of collectibles to nft.

Fixes: #14502

@NidhiKJha NidhiKJha added area-NFTs team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Dec 9, 2022
@NidhiKJha NidhiKJha requested review from a team and kumavis as code owners December 9, 2022 12:06
@NidhiKJha NidhiKJha mentioned this pull request Dec 13, 2022
Open
mcmire
mcmire reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! This seems like a lot of comments, but all of them are around touching up the wording so that when "NFT" appears in a sentence it is always capitalized and preceded by "an".

app/_locales/en/messages.json Outdated Show resolved Hide resolved
app/_locales/en/messages.json Outdated Show resolved Hide resolved
app/_locales/de/messages.json Outdated Show resolved Hide resolved
app/_locales/el/messages.json Outdated Show resolved Hide resolved
app/_locales/el/messages.json Outdated Show resolved Hide resolved
ui/store/actions.js Outdated Show resolved Hide resolved
ui/store/actions.js Outdated Show resolved Hide resolved
ui/store/actions.js Outdated Show resolved Hide resolved
ui/store/actions.js Outdated Show resolved Hide resolved
ui/store/actions.js Outdated Show resolved Hide resolved
@NidhiKJha NidhiKJha force-pushed the collectibles-to-nft branch from 27c7c87 to 6d0543a Compare January 16, 2023 17:48
@NidhiKJha NidhiKJha marked this pull request as draft January 16, 2023 18:20
@NidhiKJha NidhiKJha closed this Feb 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt left review comments

@mcmire mcmire mcmire left review comments

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

@brad-decker brad-decker Awaiting requested review from brad-decker brad-decker is a code owner automatically assigned from MetaMask/extension-devs

@adonesky1 adonesky1 Awaiting requested review from adonesky1

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
area-NFTs team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all instances of Collectible to NFT in both Extension and Controller's repos
4 participants
@NidhiKJha @mcmire @Gudahtt @pedronfigueiredo