Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update front end #5

Closed
wants to merge 36 commits into from
Closed

Feat/update front end #5

wants to merge 36 commits into from

Conversation

k-g-j
Copy link
Contributor

@k-g-j k-g-j commented Jan 22, 2024

In this PR:

  • Add config for setting custom addresses, urls, etc. . . . per chain for aa methods
  • Addresses bugs found by Matt Walsh
  • Adds to the testing suite
  • Adds userOp methods to front-end (to be removed in subsequent PR)

k-g-j and others added 30 commits January 11, 2024 12:12
@k-g-j
feat: init commit with createAccount and state updates
97f4eb4
@k-g-j
feat: init commit with createAccount and state updates
958ee49
@k-g-j
Added [email protected] to dependencies
2cdfde5
@k-g-j
Added sign transaction to unsupported methods
4ebffef
@k-g-j
Added initCode generation to createAccount
10be421
@k-g-j
Removed unnecessary error throw and set deployed to false in createAc…
cabd8fd 
…count
@k-g-j
Init: removed async methods and flows
995518b
@k-g-j
Added method stubs for user operations
a6e7d77
@k-g-j
Started implementing method to prepare userOp
53629a4
@k-g-j
Finished implementing prepareUserOp
187e6e4
@k-g-j
Merge remote-tracking branch 'origin/feat/deploy-factories' into feat…
c9e90f1 
…/implement-4337-methods

# Conflicts:
#	packages/snap/package.json
#	packages/snap/src/constants/aa-factories.ts
#	packages/snap/src/constants/chain-ids.ts
#	packages/snap/src/keyring.ts
#	yarn.lock
@k-g-j
Updated implementation for preparing and signing requests and merged …
7e62b2c 
…with deploy contracts branch
@k-g-j
Updated dummy values and added urls to env.sample
174178f
@k-g-j
Updated paymaster url in env.sample
fea673b
@k-g-j
Added salt to wallet state and address for paymaster to env.sample
24ac8da
@montelaidev
feat: impl patchUserOperation
b0ca7da
@montelaidev
fix: add network-access permission
1f2ab26
@montelaidev
fix: return types for prepareUserOperation
32d20d9
@montelaidev
fix: SimpleAccountFactory getAddress to getAccountAddress
70269f2
@montelaidev
fix: update keyring api on site
7fbedce
@montelaidev
fix: change salt to be dynamic
daced3d
@k-g-j
updated front end to import private key in create account and include…
c719043 
… userOp methods
@k-g-j
Updated snap name on front end
5aed321
@montelaidev
Merge remote-tracking branch 'origin/feat/update-front-end' into feat…
e3bab75 
…/implement-patch-user-operation
@montelaidev
feat: update hardhat config with chainId and max accounts
73fb85f
@montelaidev
fix: sign userOperation
40aa29f
@montelaidev
chore: update readme
5f922ca
@montelaidev
fix: patchUserOperation to use verifying paymaster
0d894b7
@k-g-j
Added salt ability to front end create account
bda37af
@k-g-j
Added ability to set chain configuration via keyring and UI
1691b81
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: environment, filesystem, network, shell, unsafe +167 47.7 MB metamaskbot
npm/@uniswap/[email protected] environment +13 1.45 MB zzmp
npm/[email protected] None 0 218 kB mikemcl
npm/[email protected] None 0 322 kB google-wombot
npm/[email protected] None 0 10.9 kB mikemcl

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
No contributors or author data npm/[email protected]
No contributors or author data npm/@uniswap/[email protected]

View full report↗︎

Next steps

Why is contributor and author data important?

Package does not specify a list of contributors or an author in package.json.

Add a author field or contributors array to package.json.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@montelaidev
Copy link
Contributor

Code contained in #4

livingrockrises added a commit to bcnmy/smart-account-keyring-template that referenced this pull request Feb 24, 2024
@livingrockrises
Merge pull request MetaMask#5 from livingrockrises/m_main_biconomy_pa…
c1ad791 
…ymasters

M main biconomy paymasters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-g-j @montelaidev