Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Userop Methods and Fixes Create Account #4

Merged
merged 60 commits into from
Jan 24, 2024
Merged

Feat: Add Userop Methods and Fixes Create Account #4

merged 60 commits into from
Jan 24, 2024

Conversation

montelaidev
Copy link
Contributor

This Pr:

  • fixes create account,
  • implements the user op methods

k-g-j and others added 26 commits January 11, 2024 12:12
@k-g-j
feat: init commit with createAccount and state updates
97f4eb4
@k-g-j
feat: init commit with createAccount and state updates
958ee49
@k-g-j
Added [email protected] to dependencies
2cdfde5
@k-g-j
Added sign transaction to unsupported methods
4ebffef
@k-g-j
Added initCode generation to createAccount
10be421
@k-g-j
Removed unnecessary error throw and set deployed to false in createAc…
cabd8fd 
…count
@k-g-j
Init: removed async methods and flows
995518b
@k-g-j
Added method stubs for user operations
a6e7d77
@k-g-j
Started implementing method to prepare userOp
53629a4
@montelaidev
feat: add env sample and update hardhat config
5b69559
@montelaidev
feat: add deployment script for factories
b0c22cd
@k-g-j
Finished implementing prepareUserOp
187e6e4
@k-g-j
Merge remote-tracking branch 'origin/feat/deploy-factories' into feat…
c9e90f1 
…/implement-4337-methods

# Conflicts:
#	packages/snap/package.json
#	packages/snap/src/constants/aa-factories.ts
#	packages/snap/src/constants/chain-ids.ts
#	packages/snap/src/keyring.ts
#	yarn.lock
@k-g-j
Updated implementation for preparing and signing requests and merged …
7e62b2c 
…with deploy contracts branch
@k-g-j
Updated dummy values and added urls to env.sample
174178f
@k-g-j
Updated paymaster url in env.sample
fea673b
@k-g-j
Added salt to wallet state and address for paymaster to env.sample
24ac8da
@montelaidev
feat: impl patchUserOperation
b0ca7da
@montelaidev
fix: add network-access permission
1f2ab26
@montelaidev
fix: return types for prepareUserOperation
32d20d9
@montelaidev
fix: SimpleAccountFactory getAddress to getAccountAddress
70269f2
@montelaidev
fix: update keyring api on site
7fbedce
@montelaidev
fix: change salt to be dynamic
daced3d
@k-g-j
updated front end to import private key in create account and include…
c719043 
… userOp methods
@k-g-j
Updated snap name on front end
5aed321
@montelaidev
Merge remote-tracking branch 'origin/feat/update-front-end' into feat…
e3bab75 
…/implement-patch-user-operation
@socket-security Socket Security
Copy link

socket-security bot commented Jan 19, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: environment, network +23 4.64 MB metamaskbot
npm/[email protected] environment, unsafe +12 473 kB isaacs
npm/[email protected] network, unsafe Transitive: environment, eval +8 143 kB dougwilson

🚮 Removed packages: npm/@babel/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@juggle/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@minoru/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@puppeteer/[email protected], npm/@react-dnd/[email protected], npm/@react-dnd/[email protected], npm/@react-dnd/[email protected], npm/@redux-saga/[email protected], npm/@redux-saga/[email protected], npm/@redux-saga/[email protected], npm/@redux-saga/[email protected], npm/@redux-saga/[email protected], npm/@redux-saga/[email protected], npm/@reduxjs/[email protected], npm/@remix-run/[email protected], npm/@testing-library/[email protected], npm/@tootallnate/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@wdio/[email protected], npm/@wdio/[email protected], npm/@wdio/[email protected], npm/@wdio/[email protected], npm/@wdio/[email protected], npm/@wdio/[email protected], npm/@zag-js/[email protected], npm/@zag-js/[email protected], npm/@zag-js/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Jan 19, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

k-g-j and others added 21 commits January 23, 2024 12:29
@k-g-j @montelaidev
Fix: return '0x' for dummy paymaster and data
0ad1e23
@k-g-j @montelaidev
Fix: do not destructure transaction array in prepareUserOp
0f28579
@k-g-j @montelaidev
Updated TODOs for validation and setting if an account is deployed
50c3821
@k-g-j @montelaidev
Added validation to setting the config
fa6e101
@k-g-j @montelaidev
Removed userOp methods from front-end
2587ba4
@montelaidev
fix: tests
4fe9247
@montelaidev
fix: verifying paymaster test
31b9f92
@montelaidev
fix: lint
b870f25
@montelaidev
feat: add .prettierignore
d01e3f2
@montelaidev
fix: remove unused variables
0a369aa
@montelaidev
fix: update env files for snap
9a62f45
@montelaidev
fix: add build step for test to create types
bcefc98
@montelaidev
fix: remove @uniswap/sdk-core
ba50085
@montelaidev
bump: metamask/providers
bce4f41
@montelaidev
fix: dynamically set networks based on env
0b83f14
@montelaidev
chore: update yarn lock
c76281c
@montelaidev
chore: fix lint
f209e44
@montelaidev
fix: remove prettier for cache, coverage and artifacts
fca138a
@montelaidev
fix: lint
194227a
@montelaidev
fix: lint
376e4a3
@montelaidev
fix: remove unneeded deps
1a0adcf
@montelaidev
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected]

@montelaidev montelaidev requested a review from k-g-j January 24, 2024 15:59
@k-g-j k-g-j merged commit cee4dc2 into main Jan 24, 2024
14 checks passed
@montelaidev montelaidev mentioned this pull request Jan 25, 2024
Closed
@montelaidev montelaidev deleted the feat/implement-patch-user-operation branch February 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-g-j k-g-j k-g-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montelaidev @k-g-j