Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump all dependencies #105

Merged
merged 5 commits into from
Oct 7, 2023
Merged

deps: Bump all dependencies #105

merged 5 commits into from
Oct 7, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 6, 2023 •
edited
Loading

  • Bump all runtime dependencies. Makes sure users have latest security- and bug fixes.
  • Move @types/punycode from dependencies to devDependencies

Blocking

@legobeat legobeat requested a review from a team as a code owner September 6, 2023 06:29
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@socket-security
Copy link

socket-security bot commented Sep 6, 2023 •
edited
Loading

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

This was referenced Sep 6, 2023
Merged
Merged
Merged
mcmire
mcmire approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit 678ab23 into MetaMask:main Oct 7, 2023
16 checks passed
@legobeat
Copy link
Contributor Author

legobeat commented Oct 7, 2023

CI tests are now failing on main after merging this: https://github.com/MetaMask/phishing-warning/actions/runs/6438549852/job/17485178317

However, this actually seems unrelated, as they were already occurring here prior: d41fd02

@legobeat legobeat mentioned this pull request Nov 2, 2023
Closed
@legobeat legobeat mentioned this pull request Sep 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@NicholasEllul NicholasEllul Awaiting requested review from NicholasEllul

@DDDDDanica DDDDDanica Awaiting requested review from DDDDDanica

@PeterYinusa PeterYinusa Awaiting requested review from PeterYinusa

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire