Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome/Edge v117 regression #119

Closed
legobeat opened this issue Nov 2, 2023 · 2 comments · Fixed by #120
Closed

Chrome/Edge v117 regression #119

legobeat opened this issue Nov 2, 2023 · 2 comments · Fixed by #120

Comments

@legobeat
Copy link
Contributor

legobeat commented Nov 2, 2023

For some reason, the Playwright CI jobs are now failing on main.

However, CI was failing with the same error prior to the merge of #105 in parallel open PRs at the time: d41fd02

So it seems likely this is actually a browser regression. Browser versions are fetched dynamically.

  • Failing Chrome version: 117.0.5938.132
  • Passing Chrome version: 116.0.5845.140
  • Failing Edge version: 117.0.2045.40
  • Passing Edge version: 116.0.1938.62
@legobeat legobeat changed the title Playwright tests regression Chrome/Edge v117 regression Nov 2, 2023
@legobeat legobeat mentioned this issue Nov 2, 2023
1 task
@brad-decker
Copy link
Contributor

Edge failing tests are due to lockdown:

[
  'Lockdown failed: TypeError: At intrinsics.Object.groupBy expected boolean not function\n' +
    '  at isAllowedPropertyValue (http://localhost:8080/lockdown-install.js:1:53384)\n' +
    '  at isAllowedProperty (http://localhost:8080/lockdown-install.js:1:53807)\n' +
    '  at visitProperties (http://localhost:8080/lockdown-install.js:1:55095)\n' +
    '  at isAllowedPropertyValue (http://localhost:8080/lockdown-install.js:1:53041)\n' +
    '  at isAllowedProperty (http://localhost:8080/lockdown-install.js:1:53807)\n' +
    '  at visitProperties (http://localhost:8080/lockdown-install.js:1:55095)\n' +
    '  at http://localhost:8080/lockdown-install.js:1:55523\n' +
    '  at repairIntrinsics (http://localhost:8080/lockdown-install.js:1:144597)\n' +
    '  at http://localhost:8080/lockdown-install.js:1:145462\n' +
    '  at http://localhost:8080/lockdown-run.js:6:3',
  'Protecting intrinsics failed: ReferenceError: harden is not defined\n' +
    '  at http://localhost:8080/lockdown-more.js:67:11\n' +
    '  at Set.forEach (<anonymous>)\n' +
    '  at protectIntrinsics (http://localhost:8080/lockdown-more.js:43:22)\n' +
    '  at http://localhost:8080/lockdown-more.js:85:5',
  "Error: Missing 'hostname' query parameter\n" +
    '  at HTMLDocument.<anonymous> (http://localhost:8080/bundle.js:17:87510)'
]

Only one error should be in that array but there are two more due to lockdown

@brad-decker
Copy link
Contributor

Same for chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants