Updating colors and typography to use theme objects #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
georgewrmarshall
changed the title
Cal-L
reviewed
Jun 16, 2022
georgewrmarshall
force-pushed
the
update/4473/theme-hook
branch
from
6d9df45 to
77616f9
Compare
georgewrmarshall
added
area-UI
and removed
DO-NOT-MERGE
georgewrmarshall
force-pushed
the
update/4473/theme-hook
branch
from
77616f9 to
6ca6fc2
Compare
georgewrmarshall
changed the title
jpcloureiro
approved these changes
Jun 22, 2022
georgewrmarshall
force-pushed
the
update/4473/theme-hook
branch
from
6ca6fc2 to
a17589b
Compare
wachunei
reviewed
Jun 28, 2022
| import { ThemeTypography } from '@metamask/design-tokens/dist/js/typography/types'; | ||
|
|
||
| // TODO: This should probably be defined from @metamask/design-token library | ||
| export type Colors = any; |
There was a problem hiding this comment.
Removing this type is breaking our ts files.
I think it should have been kept as Colors: DesignTokenTheme['colors'];.
We use them in the aggregator views:
Do we have type check enabled? This should have been caught at that stage.
Cal-L
added
the
release-5.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating
colorsandtypographyobjects to use thelightThemeanddarkThemeobjects from design tokensv1.7. The next step would be to add athemeobject to the context so the root theme can be changed and passed through the provider instead of individual objects.Dependencies
MetaMask/design-tokens#148 has to be merged and package updated in mobile before this can be merged. ✅
Checklist
[x] Tests are included if applicableNA[x] Any added code is fully documentedNAScreenshots/Recordings
Issue
#4473