This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [aaad3a5]
|
Builds ready [cc51e47]
|
georgewrmarshall
force-pushed
the
update/141/css-in-js-architecture
branch
from
June 6, 2022 23:01
cc51e47
to
b2dc8d1
Compare
georgewrmarshall
force-pushed
the
update/141/css-in-js-architecture
branch
from
June 6, 2022 23:02
b2dc8d1
to
8963807
Compare
Builds ready [8963807]
|
georgewrmarshall
force-pushed
the
update/141/css-in-js-architecture
branch
from
June 6, 2022 23:20
8963807
to
0a298ce
Compare
Builds ready [0a298ce]
|
Builds ready [2f6aa8a]
|
This was referenced Jun 8, 2022
Cal-L
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #141 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the CSS-in-JS architecture to include themes so we can change the theme object at the top level without worrying about constructing theme specific styles further down the tree e.g combining color with shadow.
src/js/themes/
directory and import global tokens fromsrc/js
lightTheme
anddarkTheme
objects are exported and will contain all design tokens color, typography etc.This could be how the new theme tokens could work
To do