Move externally_connectable from base to Chrome manifest
#9824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `externally_connectable` property of the extension manifest is not recognized by Firefox. It has been moved from the base manifest to the Chrome manifest, so that we no longer get a warning about this property on Firefox. We would like to eventually remove it from the Chrome manifest as well, but we'll wait until we can batch it with other permission changes so that it doesn't unnecessarily re-prompt the user (see #9804)
Builds ready [f0fda1f]
Page Load Metrics (376 ± 42 ms)
|
rekmarks
approved these changes
Nov 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
externally_connectableproperty of the extension manifest is not recognized by Firefox. It has been moved from the base manifest to the Chrome manifest, so that we no longer get a warning about this property on Firefox.We would like to eventually remove it from the Chrome manifest as well, but we'll wait until we can batch it with other permission changes so that it doesn't unnecessarily re-prompt the user (see #9804)