Skip to content

Commit

Permalink
Move externally_connectable from base to Chrome manifest (#9824)
Browse files Browse the repository at this point in the history
The `externally_connectable` property of the extension manifest is not
recognized by Firefox. It has been moved from the base manifest to the
Chrome manifest, so that we no longer get a warning about this property
on Firefox.

We would like to eventually remove it from the Chrome manifest as well,
but we'll wait until we can batch it with other permission changes so
that it doesn't unnecessarily re-prompt the user (see #9804)
  • Loading branch information
Gudahtt authored Nov 9, 2020
1 parent 4ef908a commit 248f171
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 0 additions & 4 deletions app/manifest/_base.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@
],
"default_locale": "en",
"description": "__MSG_appDescription__",
"externally_connectable": {
"matches": ["https://metamask.io/*"],
"ids": ["*"]
},
"icons": {
"16": "images/icon-16.png",
"19": "images/icon-19.png",
Expand Down
4 changes: 4 additions & 0 deletions app/manifest/chrome.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
{
"externally_connectable": {
"matches": ["https://metamask.io/*"],
"ids": ["*"]
},
"minimum_chrome_version": "58"
}

0 comments on commit 248f171

Please sign in to comment.