Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connect long URL styling #8719

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Fix connect long URL styling #8719

merged 4 commits into from
Jun 1, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jun 1, 2020 •
edited
Loading

Long URLs were overflowing on the connected sites page.

Before
After

@rekmarks rekmarks requested a review from a team as a code owner June 1, 2020 21:51
brad-decker
brad-decker previously approved these changes Jun 1, 2020
View reviewed changes
@rekmarks rekmarks requested a review from brad-decker June 1, 2020 21:55
Gudahtt
Gudahtt reviewed Jun 1, 2020
View reviewed changes
ui/app/components/app/permissions-connect-header/index.scss
width: 100%;
text-overflow: ellipsis;
overflow: hidden;
direction: rtl;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I was about to comment on this! You beat me to it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I was like, "DAMN IT DAMN IT DAMN IT PUSH PUSH PUSH" 😂

Gudahtt
Gudahtt approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [05f088c]
Page Load Metrics (629 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32128522914
domContentLoaded3518006288842
load3528026298842
domInteractive3517996288842

@rekmarks rekmarks merged commit 8afb295 into develop Jun 1, 2020
@rekmarks rekmarks deleted the permissions-overflow-styling branch June 1, 2020 22:28
Gudahtt added a commit that referenced this pull request Jun 1, 2020
@Gudahtt
Merge remote-tracking branch 'origin/develop' into Version-v8.0.0
07dee72 
* origin/develop:
  Fix connect long URL styling (#8719)
  Add nonce to transaction details (#8716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @metamaskbot @Gudahtt @brad-decker