Add nonce to transaction details #8716
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
force-pushed
the
add-nonce-to-details
branch
from
0c24834 to
5f7d60e
Compare
Gudahtt
reviewed
Jun 1, 2020
| const { gas, gasPrice, value, className, nativeCurrency, showFiat, totalInHex, gasUsed } = this.props | ||
|
|
||
| const { gas, gasPrice, value, className, nonce, nativeCurrency, showFiat, totalInHex, gasUsed } = this.props | ||
| console.log(nonce) |
There was a problem hiding this comment.
Leftover console.log here
Suggested change
| console.log(nonce) |
| className="transaction-breakdown__value" | ||
| value={nonce} | ||
| /> | ||
| ) : '?' |
There was a problem hiding this comment.
I would recommend using "Unknown" here, since we already have it as a localized message
Suggested change
| ) : '?' | |
| ) : t('unknown') |
There was a problem hiding this comment.
Or just leave it blank, perhaps? 🤔
Suggested change
| ) : '?' | |
| ) : null |
brad-decker
force-pushed
the
add-nonce-to-details
branch
from
5f7d60e to
411f399
Compare
Builds ready [411f399]
Page Load Metrics (607 ± 62 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8564 removed the nonce from the transaction list item UI as per the design, but the design intended for the nonce to be relocated into the new transaction details view. #8564 used an incremental approach for implementing new designs and simply moved the details into a popover but did not implement the new UI. Therefore, the nonce was erroneously removed from the user's view.
This PR is extending the old details UI to add the nonce to it until I can implement the new design.