Add loading view to notification.html #6648
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjeria - can you comment on my design for the loading screen? 😃 |
chikeichan
commented
May 23, 2019
| <div id="app-content"></div> | ||
| <div id="app-content"> | ||
| <img id="loading__logo" src="./images/logo/metamask-fox.svg" /> | ||
| <img id="loading__spinner" src="./images/spinner.gif" /> |
There was a problem hiding this comment.
It has to be a gif because scripting time actually blocks css animations too.
danjm
approved these changes
May 27, 2019
Closed
|
What you've put together looks perfectly fine. I'm noticing however there are two different loading indicator versions in your example gif. Let's use just one for consistency and make it gray #bbc0c5. This one... And this one that appears for a split second after the signing... I'll leave it up to you to choose which one to use. |
|
I'll provide a GIF of the second loading indicator since the loading screen can only use GIF, no code version of a loading indicator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a initial loading screen to the raw html file - this will allow the loading screen to be painted almost instantaneous, giving user feedback that something is happening instead of a blank screen. This relates to #6590
Here is some research into the issue (on a 2017 MBP) on current production build 6.5.3:
I have created issues #6644, #6645, #6646 , #6647 to capture the rest of the work toward optimizing load time.