Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate entry point for a notification.js build #6644

Closed
2 tasks
chikeichan opened this issue May 23, 2019 · 2 comments
Closed
2 tasks

Create separate entry point for a notification.js build #6644

chikeichan opened this issue May 23, 2019 · 2 comments
Assignees
@Gudahtt @chikeichan
Milestone
UI Sprint 17 [Jul...

Comments

@chikeichan
Copy link
Contributor

chikeichan commented May 23, 2019 •
edited
Loading

  • add new notification.js build to create new bundle for notification.html
  • replace ui.js with new bundle in notification.html
@chikeichan chikeichan self-assigned this May 23, 2019
@chikeichan chikeichan mentioned this issue May 23, 2019
Merged
@danjm danjm added this to the UI Sprint 13 [May 27] milestone May 27, 2019
@chikeichan chikeichan mentioned this issue Jun 4, 2019
Closed
@bdresser bdresser removed this from the UI Sprint 13 [May 27] milestone Jul 8, 2019
@Gudahtt Gudahtt added this to the UI Sprint 16 [July 8] milestone Jul 18, 2019
@Gudahtt Gudahtt self-assigned this Jul 18, 2019
@danfinlay
Copy link
Contributor

danfinlay commented Jan 5, 2021 •
edited
Loading

closing this for now, since we have done some of this refactor work.

@Gudahtt
Copy link
Member

Gudahtt commented Jan 5, 2021 •
edited
Loading

We didn't actually make any headway on this after, as the performance improvements were negligible due to how we're generating our bundles. The last time I looked into this, my conclusion was that we needed to omit more unused code from our bundles for this approach to be effective at improving performance.

Great strides are made towards this in #8170 - so a natural follow-up to that PR might be to re-introduce this separate notification entrypoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gudahtt Gudahtt

@chikeichan chikeichan

Labels
None yet
Projects
None yet
Milestone
UI Sprint 17 [July 22]
Development

No branches or pull requests
5 participants
@danfinlay @bdresser @Gudahtt @danjm @chikeichan