getMethodData() default to abi decoded method if registry lookup errors #6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
default-method-name-to-abi-lookup
branch
from
f2ecbcc to
afe116e
Compare
danjm
added a commit
that referenced
this pull request
Mar 29, 2019
vittominacori
added a commit
to vittominacori/metamask-extension
that referenced
this pull request
Apr 3, 2019
* 'master' of https://github.com/MetaMask/metamask-extension: (84 commits) Version 6.3.1 Check token name constants against the lower case methodData name in conf tx switch container. Ensure correct confirm screen in case of smartcontract check fail About tab copy changes; Update route for Info & Help in account menu (MetaMask#6356) Revert to providing inline defaults in getHexGasTotal and increaseLastGasPrice (MetaMask#6361) Further e2e fixes in wake of MetaMask#6364 and MetaMask#6367 (MetaMask#6374) Split e2e run-all commands onto multiple lines Run from-import e2e tests with additional account, to avoid conflict with accounts in earlier test runs Use localhost instead of mainnent/infura for custom rpc tests in e2e tests. ci: Add build:test Gulp task for e2e build e2e: Update Contract Interaction wording e2e: Skip approving token test send-footer.utils.js - addressIsNew - improve readability test - unit - ui - actions - setCompletedOnboarding - fix stub to call callback lint fix actions - setCompletedOnboarding - make async with pify notice-controller - make markAllNoticesRead sync lib - nodeify - correctly wrap synchronous functions notices - markAllNoticesRead - use async/await buy-eth-url - lint fix ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that was causing the confirm screen to navigate to the simple send confirm screen when it should have been navigating to the token transfer confirm screen. This could happen in when the http request made by "registry.lookup" failed.
Our router depends on the contract method name when the registry lookup failed, the name passed to the router was undefined.
This PR adds a fallback in our
getMethodData()function - the use of abiDecoder.decodeMethod -which prevents the above described issue. W