Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About tab copy changes; Update route for Info & Help in account menu #6356

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

chikeichan
Copy link
Contributor

setting

@whymarrh whymarrh force-pushed the info-tab-copy-change branch from 179d7d1 to b6f0a27 Compare March 29, 2019 16:12
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whymarrh whymarrh merged commit adcf03e into MetaMask:develop Mar 29, 2019
vittominacori added a commit to vittominacori/metamask-extension that referenced this pull request Apr 3, 2019
* 'master' of https://github.com/MetaMask/metamask-extension: (84 commits)
  Version 6.3.1
  Check token name constants against the lower case methodData name in conf tx switch container.
  Ensure correct confirm screen in case of smartcontract check fail
  About tab copy changes; Update route for Info & Help in account menu (MetaMask#6356)
  Revert to providing inline defaults in getHexGasTotal and increaseLastGasPrice (MetaMask#6361)
  Further e2e fixes in wake of MetaMask#6364 and MetaMask#6367 (MetaMask#6374)
  Split e2e run-all commands onto multiple lines
  Run from-import e2e tests with additional account, to avoid conflict with accounts in earlier test runs
  Use localhost instead of mainnent/infura for custom rpc tests in e2e tests.
  ci: Add build:test Gulp task for e2e build
  e2e: Update Contract Interaction wording
  e2e: Skip approving token test
  send-footer.utils.js - addressIsNew - improve readability
  test - unit - ui - actions - setCompletedOnboarding - fix stub to call callback
  lint fix
  actions - setCompletedOnboarding - make async with pify
  notice-controller - make markAllNoticesRead sync
  lib - nodeify - correctly wrap synchronous functions
  notices - markAllNoticesRead - use async/await
  buy-eth-url - lint fix
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants