Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy mode fixes #6087

Merged
merged 5 commits into from
Feb 1, 2019
Merged

Privacy mode fixes #6087

merged 5 commits into from
Feb 1, 2019

Conversation

brunobar79
Copy link
Contributor

FIxes 2 separate issues related to #6006

  • Fixes error triggered by the meshtesting iframe, calling the provider approval API without containing a tabID by ignoring messages without tabID

  • Fix the approval screen on the old UI

@metamaskbot
Copy link
Collaborator

Builds ready [d7c0b67]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [04d6ae1]: mascara, chrome, firefox, edge, opera

Copy link
Contributor

@bitpshr bitpshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

I think only the old UI code fix is needed. Since we're already using a switch statement on a message's action property, no case should be triggered by a mesh testing event unless it has an action we're looking for.

@brunobar79
Copy link
Contributor Author

brunobar79 commented Feb 1, 2019

Merging this one in and we can roll it back later if we decide there's a better fix for the messages triggered from our iframes.

@brunobar79 brunobar79 merged commit cc03a7d into develop Feb 1, 2019
@whymarrh whymarrh deleted the privacy-mode-hotfix branch November 19, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants