Privacy mode fixes (#6087)

* Version 5.3.4 RC1 * fix old ui approval screen * fix error caused by meshtesting iframe * fix linter errors
MetaMask · Feb 1, 2019 · cc03a7d · cc03a7d
1 parent 015414c
commit cc03a7d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/app/scripts/controllers/provider-approval.js b/app/scripts/controllers/provider-approval.js
@@ -28,19 +28,21 @@ class ProviderApprovalController {
 
     if (platform && platform.addMessageListener) {
       platform.addMessageListener(({ action = '', force, origin, siteTitle, siteImage }, { tab }) => {
-        switch (action) {
-          case 'init-provider-request':
-            this._handleProviderRequest(origin, siteTitle, siteImage, force, tab.id)
-            break
-          case 'init-is-approved':
-            this._handleIsApproved(origin, tab.id)
-            break
-          case 'init-is-unlocked':
-            this._handleIsUnlocked(tab.id)
-            break
-          case 'init-privacy-request':
-            this._handlePrivacyRequest(tab.id)
-            break
+        if (tab && tab.id) {
+          switch (action) {
+            case 'init-provider-request':
+              this._handleProviderRequest(origin, siteTitle, siteImage, force, tab.id)
+              break
+            case 'init-is-approved':
+              this._handleIsApproved(origin, tab.id)
+              break
+            case 'init-is-unlocked':
+              this._handleIsUnlocked(tab.id)
+              break
+            case 'init-privacy-request':
+              this._handlePrivacyRequest(tab.id)
+              break
+          }
         }
       })
     }

diff --git a/old-ui/app/app.js b/old-ui/app/app.js
@@ -219,7 +219,7 @@ App.prototype.renderPrimary = function () {
 
   if (providerRequests && providerRequests.length > 0) {
     log.debug('rendering provider API approval screen')
-    return h(ProviderApproval, { origin: providerRequests[0].origin })
+    return h(ProviderApproval, { origin: providerRequests[0].origin, tabID: providerRequests[0].tabID })
   }
 
   // show current view