-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent send to token warning #6058
Conversation
Code changes look good to me! @estebanmino could you add a screen shot or gif showing what the warning looks like? |
Sure there is a GIF As you can see, sending HACK to the address HACK (or any token added manually) or any contract in contract-metadata it will show a If we want to change the color or anything else in that message we just need to modify @danjm let me know if we want to change the color of the message or something else. |
@estebanmino Yeah, let's change the color to orange, as it is just a warning. For example, see the different warning colours we have in the speed up sidebar. Otherwise this looks good to merge. |
@danjm changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following #6051
This PR adds this validation as a warning instead of an error. With this the user will see
Known contract address.
as an error but is still possible to send the transaction.This PR also adds a new object to the
send
state, calledwarnings
. For now rendered with the componentSendRowWarningMessage
as the errors, but the idea of this is to easily modify the way we want to show warnings to users, without blocking the transaction validation.