Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent send to token #6051

Merged
merged 7 commits into from
Jan 22, 2019
Merged

Prevent send to token #6051

merged 7 commits into from
Jan 22, 2019

Conversation

estebanmino
Copy link
Contributor

This PR prevents users to send tokens to contract addresses in eth-contract-metadata or tokens added manually.

GIF to show the UX

prevent

The first address is "HACK" address, the second one is one from eth-contract-metadata.

Fixes #3185

@metamaskbot
Copy link
Collaborator

Builds ready [6dd7b69]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [ce2d48a]: mascara, chrome, firefox, edge, opera

Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great user protection, thank you!

@JiimyZee
Copy link

JiimyZee commented Feb 6, 2024

When were any of these "known contract warnings" actually implemented because I can see you all have been working on this since 2016?

Copy link
Contributor

github-actions bot commented Feb 6, 2024

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@estebanmino

@JiimyZee
Copy link

JiimyZee commented Feb 6, 2024

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA. ❌ @estebanmino

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn users when sending tokens to the token address
4 participants