-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent send to token #6051
Prevent send to token #6051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great user protection, thank you!
When were any of these "known contract warnings" actually implemented because I can see you all have been working on this since 2016? |
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 0 out of 1 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA |
This PR prevents users to send tokens to contract addresses in
eth-contract-metadata
or tokens added manually.GIF to show the UX
The first address is "HACK" address, the second one is one from
eth-contract-metadata
.Fixes #3185