Consider HW Wallets for signTypedMessage #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
requested review from
bitpshr,
danfinlay and
whymarrh
and removed request for
bitpshr and
danfinlay
brunobar79
changed the title
brunobar79
changed the title
brunobar79
changed the title
brunobar79
changed the title
whymarrh
reviewed
Nov 22, 2018
bitpshr
previously approved these changes
Nov 25, 2018
bitpshr
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That feature it's not currently supported on Ledger or Trezor but the current implementation of signedTypedData was reading private keys from the keyring, which is a private method and not supported on the HW wallet keyrings.
This PR handles both scenarios separately and at least now we will fail with the right error message:
Not supported in this deviceOnce the hw wallets gets support, we should have to just update the keyring without need of touching the extension.
Fixes #5319
BEFORE:
AFTER:
