Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger hardware wallet is not supported #3

Closed
valo opened this issue Feb 28, 2020 · 1 comment
Closed

Ledger hardware wallet is not supported #3

valo opened this issue Feb 28, 2020 · 1 comment

Comments

@valo
Copy link

valo commented Feb 28, 2020

Seems like the library uses the signTypedMessage method, which is currently not supported by hardware wallets like Ledger. See MetaMask/metamask-extension#5792

The error that is received upon trying to sign the message:

MetaMask - RPC Error: MetaMask Message Signature: Error: Not supported on this device

I am wondering if it's possible to use a different type of signature, so that hardware wallets can be supported. This problem will be a significant obstacle in implementing the gasless system for a mainstream usage.

@nourharidy
Copy link
Collaborator

nourharidy commented Feb 28, 2020

Unfortunately, EIP712's signTypedData is required by the MCD DAI contract.

That being said, it may be possible to use web3-provider-engine to construct an intermediate web3 provider and support signTypedData by creating a provider middleware which would use Ledger's plain signatures to construct signTypedData signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants