Add notification for dropped retry transactions #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alextsg Looks good. However, on the second screenshot above, the "speed up" screen should still be behind the alert dialog. Looks like it disappears from the view? |
|
Code looks good, except that I am reminded that we really need to eliminate the code duplication between the confirm components. I'll approve after the changes needed to address Christian's comment above. |
|
@cjeria After diving into the confirm transaction code more, I don't think there's currently a quick way for us to keep the data for the confirm screen without possibly introducing other concerns. We'll definitely address this in the task to refactor the confirm transaction flow and make sure your concerns are resolved when that's done. |
cjeria
approved these changes
May 26, 2018
danjm
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4018, changes some styling/wording related to #3885
This PR adds a popup to be shown when the user is retrying a previous transaction while that previous transaction is confirmed. This PR also introduces using optional params in the URL - when retrying a transaction the new transaction's ID will be used as a param so that we can avoid using
indexto retrieve the transaction object. If no param is present then we fall back toindex.@cjeria
