Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reprice" TX UI Feedback #3885

Closed
cjeria opened this issue Apr 5, 2018 · 6 comments
Closed

"Reprice" TX UI Feedback #3885

cjeria opened this issue Apr 5, 2018 · 6 comments
Assignees
Labels
needs-design Needs design support.

Comments

@cjeria
Copy link
Contributor

cjeria commented Apr 5, 2018

If a retry/reprice/speed up tx is rejected, what's the reason behind showing the rejected event in the TX history? I believe the rejected event isn't important enough to show in the history (other tx events are more important like displaying incoming transactions). I would compare it to opening up a new text file and closing it without ever saving it. I don't need to see somewhere that I've thrown something away. I consider login and sign requests generated by a smart contract to be important to display in the tx history, but not user generated tx's.

Also some UI feedback on the "reprice" screen. I think we can reduce the overall height of data fields which would give us more vertical area to display the total cost of transaction (tx + gas price). Also wondering if we just show the total value up at the top since it's the most important piece of data @kumavis?

image

@cjeria cjeria self-assigned this Apr 5, 2018
@cjeria cjeria added the needs-design Needs design support. label Apr 5, 2018
@kumavis
Copy link
Member

kumavis commented Apr 9, 2018

I believe the rejected event isn't important enough to show in the history

makes sense, i agree

@kumavis
Copy link
Member

kumavis commented Apr 9, 2018

wondering if we just show the total value up at the top since it's the most important piece of data

understood, but caveats:

for tokens we show the number of tokens we are sending, not value of tokens in usd (not always clear), and fees are paid in eth and we dont show the fee in token value (they dont pay any tokens to perform the tx)

i think (too ideally?) that the user cares about "their action" (e.g. sending ex) and less about the fee
because its understood that there is going to be a fee, and the fee is just a negotiation about the priority of their action (gasPrice vs tx market)

@alacrity26
Copy link

@kumavis the last point is interesting. I wonder if we could throw it to users and ask what they think, or test/observe it without asking.

@cjeria
Copy link
Contributor Author

cjeria commented Apr 9, 2018

I agree with @alacrity26. Will be conducting user tests very soon.

@cjeria
Copy link
Contributor Author

cjeria commented May 17, 2018

Latest option for showing all vital transaction data above the fold (no need to scroll).
artboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-design Needs design support.
Projects
None yet
Development

No branches or pull requests

5 participants
@cjeria @bdresser @kumavis @alacrity26 and others