Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoding data display for ERC-1155 tokens #28921

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 4, 2024

Description

Signatuare decoding data was not being displayed for ERC-1155 tokens, this PR fixes it.

Related issues

Fixes: #28903

Manual testing steps

Detailed here

Screenshots/Recordings

Screenshot 2024-12-04 at 4 01 53 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Dec 4, 2024
@jpuri jpuri requested a review from a team as a code owner December 4, 2024 10:33
Copy link
Contributor

github-actions bot commented Dec 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [9cfb2b2]
Page Load Metrics (1796 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint147727511793261125
domContentLoaded147127371772259124
load148427451796258124
domInteractive235832105
backgroundConnect898262311
firstReactRender1486262010
getState1093111535124
initialActions00000
loadScripts107423171358254122
setupStore629952
uiStartup173230692116307148
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 29 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit fc8e51e Dec 4, 2024
80 of 81 checks passed
@jpuri jpuri deleted the decoding_erc_1155_fix branch December 4, 2024 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024
@jpuri jpuri restored the decoding_erc_1155_fix branch December 4, 2024 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect rendering on NFTs during signature decoding
4 participants