Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect rendering on NFTs during signature decoding #28903

Closed
mindofmar opened this issue Dec 3, 2024 · 0 comments · Fixed by #28921 or #28924
Closed

[Bug]: Incorrect rendering on NFTs during signature decoding #28903

mindofmar opened this issue Dec 3, 2024 · 0 comments · Fixed by #28921 or #28924
Assignees
@jpuri
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 release-12.10.0 Issue or pull request that will be included in release 12.10.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@mindofmar
Copy link
Contributor

mindofmar commented Dec 3, 2024 •
edited
Loading

Describe the bug

The You list section of the Estimated Changes UI is showing blank where it should show an NFT and its amount. This is also happening on OpenSea Bid requests. (see below for link to QA checklist)

image

Steps to reproduce & Expected Behavior

See QA issues.

Detection stage

During release testing

Version

12.9

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@mindofmar mindofmar added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. release-blocker This bug is blocking the next release team-confirmations Push issues to confirmations team regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 labels Dec 3, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 3, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 3, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Dec 3, 2024
@jpuri jpuri self-assigned this Dec 4, 2024
@jpuri jpuri removed the regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 label Dec 4, 2024
@jpuri jpuri mentioned this issue Dec 4, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
@jpuri
fix: decoding data display for ERC-1155 tokens (#28921)
fc8e51e 
## **Description**

Signatuare decoding data was not being displayed for ERC-1155 tokens,
this PR fixes it.

## **Related issues**

Fixes: #28903

## **Manual testing steps**
Detailed
[here](https://www.notion.so/metamask-consensys/Signature-Decoding-v12-9-QA-151f86d67d68802baddfebf3e44aea5e?pvs=4#151f86d67d6880f5a69aff17d227329d)

## **Screenshots/Recordings**
<img width="359" alt="Screenshot 2024-12-04 at 4 01 53 PM"
src="https://github.com/user-attachments/assets/b6e5096e-7b39-49cd-b012-f96c231dc7f1">

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 4, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 4, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024
@bschorchit bschorchit added the regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 label Dec 4, 2024
@jpuri jpuri mentioned this issue Dec 4, 2024
Merged
7 tasks
danjm pushed a commit that referenced this issue Dec 4, 2024
@jpuri
cherry-pick: Fix decoding data display for ERC-1155 tokens (#28924)
95a62e8 
## **Description**

Signature decoding data was not being displayed for ERC-1155 tokens,
this PR fixes it.

Original PR: #28921
Cherry-picked link:
fc8e51e

## **Related issues**

Fixes: #28903

## **Manual testing steps**
Detailed
[here](https://www.notion.so/metamask-consensys/Signature-Decoding-v12-9-QA-151f86d67d68802baddfebf3e44aea5e?pvs=4#151f86d67d6880f5a69aff17d227329d)

## **Screenshots/Recordings**
<img width="359" alt="Screenshot 2024-12-04 at 4 01 53 PM"
src="https://github.com/user-attachments/assets/b6e5096e-7b39-49cd-b012-f96c231dc7f1">

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-RC-12.9.0 Regression bug that was found in release candidate (RC) for release 12.9.0 release-12.10.0 Issue or pull request that will be included in release 12.10.0 release-blocker This bug is blocking the next release Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
4 participants
@jpuri @bschorchit @metamaskbot @mindofmar