chore: update controllers as of core release v244 #28905

cryptodev-2s · 2024-12-03T23:52:01Z

Description

This PR bumps the following packages:

@metamask/ens-controller to ^15.0.0
@metamask/network-controller to ^22.1.0
@metamask/gas-fee-controller to ^22.0.1
@metamask/user-operation-controller to ^20.0.1
@metamask/polling-controller to ^12.0.1
@metamask/selected-network-controller to ^19.0.0

Related issues

Progresses https://github.com/MetaMask/MetaMask-planning/issues/3698

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-03T23:52:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cryptodev-2s · 2024-12-03T23:52:25Z

@metamaskbot update-policies

socket-security · 2024-12-03T23:53:57Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	88.3 kB	metamaskbot
npm/@metamask/[email protected]	None	`+1`	227 kB	metamaskbot
npm/@metamask/[email protected]	environment	`0`	655 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	134 kB	metamaskbot
npm/@metamask/[email protected]	network	`0`	485 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

metamaskbot · 2024-12-04T00:02:15Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2024-12-04T00:34:22Z

Builds ready [0d6e63d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1911 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1707	2353	1915	157	76
		domContentLoaded	1689	2158	1875	138	66
		load	1704	2352	1911	158	76
		domInteractive	25	69	39	14	7
		backgroundConnect	12	188	36	38	18
		firstReactRender	15	32	21	5	2
		getState	102	310	149	53	26
		initialActions	0	1	0	0	0
		loadScripts	1271	1682	1470	122	59
		setupStore	7	83	16	22	11
		uiStartup	2004	2833	2258	228	110

Bundle size diffs [🚀 Bundle size reduced!]

background: -151.49 KiB (-2.81%)
ui: 49.18 KiB (0.63%)
common: -145.94 KiB (-1.77%)

mikesposito

LGTM!

mikesposito · 2024-12-04T12:49:39Z

Bundle size diffs [🚀 Bundle size reduced!]
background: -151.49 KiB (-2.81%)
ui: 49.18 KiB (0.63%)
common: -145.94 KiB (-1.77%)

Beautiful

mcmire

It looks like we still have peer dependency warnings on smart-transactions-controller (which wants transaction-controller 38, but we have 41) and ppom-validator (which wants network-controller 21, but we are bumping to 22).

The warning for smart-transactions-controller was already pre-existing prior to this commit. The warning for ppom-validator is okay because the changes between network-controller 21 and 22 were minimal. We can bump network-controller in ppom-validator later.

LGTM.

Gudahtt

LGTM!

metamaskbot · 2024-12-04T18:51:38Z

Builds ready [6c34361]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1732 ± 35 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1620	1981	1732	71	34
		domContentLoaded	1609	1958	1714	73	35
		load	1621	1980	1732	73	35
		domInteractive	24	73	32	13	6
		backgroundConnect	9	47	18	11	5
		firstReactRender	15	93	25	22	11
		getState	103	383	143	64	31
		initialActions	0	1	0	0	0
		loadScripts	1250	1552	1331	66	32
		setupStore	6	27	8	4	2
		uiStartup	1873	2554	2025	171	82

Bundle size diffs [🚀 Bundle size reduced!]

background: -151.49 KiB (-2.81%)
ui: 49.18 KiB (0.63%)
common: -145.94 KiB (-1.77%)

metamaskbot · 2024-12-04T22:23:57Z

Builds ready [4d19527]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1970 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1702	2317	1975	162	78
		domContentLoaded	1697	2223	1941	144	69
		load	1701	2235	1970	146	70
		domInteractive	24	52	33	7	3
		backgroundConnect	7	87	28	24	11
		firstReactRender	15	94	24	17	8
		getState	87	283	141	40	19
		initialActions	0	0	0	0	0
		loadScripts	1292	1741	1488	122	59
		setupStore	7	16	9	2	1
		uiStartup	1971	2671	2277	190	91

Bundle size diffs [🚀 Bundle size reduced!]

background: -151.49 KiB (-2.81%)
ui: 49.18 KiB (0.63%)
common: -145.94 KiB (-1.77%)

metamaskbot · 2024-12-04T22:26:02Z

Builds ready [4d19527]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1970 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1702	2317	1975	162	78
		domContentLoaded	1697	2223	1941	144	69
		load	1701	2235	1970	146	70
		domInteractive	24	52	33	7	3
		backgroundConnect	7	87	28	24	11
		firstReactRender	15	94	24	17	8
		getState	87	283	141	40	19
		initialActions	0	0	0	0	0
		loadScripts	1292	1741	1488	122	59
		setupStore	7	16	9	2	1
		uiStartup	1971	2671	2277	190	91

Bundle size diffs [🚀 Bundle size reduced!]

background: -151.49 KiB (-2.81%)
ui: 49.18 KiB (0.63%)
common: -145.94 KiB (-1.77%)

chore: update controllers as of core release v244

2ad4361

cryptodev-2s requested a review from a team as a code owner December 3, 2024 23:52

cryptodev-2s self-assigned this Dec 3, 2024

cryptodev-2s added the team-wallet-framework label Dec 3, 2024

Update LavaMoat policies

0d6e63d

metamaskbot requested a review from a team as a code owner December 4, 2024 00:02

cryptodev-2s requested review from Gudahtt and mikesposito December 4, 2024 00:47

cryptodev-2s mentioned this pull request Dec 4, 2024

chore: update controllers as of core release v262 #28781

Closed

7 tasks

mikesposito approved these changes Dec 4, 2024

View reviewed changes

mcmire approved these changes Dec 4, 2024

View reviewed changes

Gudahtt approved these changes Dec 4, 2024

View reviewed changes

cryptodev-2s enabled auto-merge December 4, 2024 17:28

desi approved these changes Dec 4, 2024

View reviewed changes

cryptodev-2s added this pull request to the merge queue Dec 4, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024

Merge branch 'main' into cryptodev2s/update-packages-release-244

99c0135

cryptodev-2s enabled auto-merge December 4, 2024 18:13

Merge branch 'main' into cryptodev2s/update-packages-release-244

6c34361

Merge branch 'main' into cryptodev2s/update-packages-release-244

4d19527

cryptodev-2s added this pull request to the merge queue Dec 4, 2024

auto-merge was automatically disabled December 4, 2024 22:28
Pull Request is not mergeable

Merged via the queue into main with commit f7fc1c9 Dec 4, 2024
81 checks passed

cryptodev-2s deleted the cryptodev2s/update-packages-release-244 branch December 4, 2024 22:34

github-actions bot locked and limited conversation to collaborators Dec 4, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update controllers as of core release v244 #28905

chore: update controllers as of core release v244 #28905

cryptodev-2s commented Dec 3, 2024 •

edited by mcmire

Loading

github-actions bot commented Dec 3, 2024

cryptodev-2s commented Dec 3, 2024

socket-security bot commented Dec 3, 2024 •

edited

Loading

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

mikesposito left a comment

mikesposito commented Dec 4, 2024

mcmire left a comment

Gudahtt left a comment

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

chore: update controllers as of core release v244 #28905

chore: update controllers as of core release v244 #28905

Conversation

cryptodev-2s commented Dec 3, 2024 • edited by mcmire Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 3, 2024

cryptodev-2s commented Dec 3, 2024

socket-security bot commented Dec 3, 2024 • edited Loading

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

mikesposito left a comment

Choose a reason for hiding this comment

mikesposito commented Dec 4, 2024

mcmire left a comment

Choose a reason for hiding this comment

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

metamaskbot commented Dec 4, 2024

cryptodev-2s commented Dec 3, 2024 •

edited by mcmire

Loading

socket-security bot commented Dec 3, 2024 •

edited

Loading