-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: update controllers as of core release v244 (#28905)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR bumps the following packages: - `@metamask/ens-controller` to `^15.0.0` - `@metamask/network-controller` to `^22.1.0` - `@metamask/gas-fee-controller` to `^22.0.1` - `@metamask/user-operation-controller` to `^20.0.1` - `@metamask/polling-controller` to `^12.0.1` - `@metamask/selected-network-controller` to `^19.0.0` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28781?quickstart=1) ## **Related issues** Fixes: #28495, MetaMask/MetaMask-planning#3698 ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: Elliot Winkler <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/28781?quickstart=1){kind=link}
- Loading branch information
3 people
authored
Dec 4, 2024
1 parent
fc06d34
commit f7fc1c9
Showing
8 changed files
with
206 additions
and
784 deletions.
There are no files selected for viewing
33 changes: 0 additions & 33 deletions
33
.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch
This file was deleted.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
.yarn/patches/@metamask-network-controller-npm-22.1.0-621c281f70.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| diff --git a/PATCH.txt b/PATCH.txt | ||
| new file mode 100644 | ||
| index 0000000000000000000000000000000000000000..ce3b18534f055ee00aa5821793f855fd300fb72c | ||
| --- /dev/null | ||
| +++ b/PATCH.txt | ||
| @@ -0,0 +1,4 @@ | ||
| +We remove lookupNetwork from initializeProvider in the network controller to prevent network requests before user onboarding is completed. | ||
| +The network lookup is done after onboarding is completed, and when the extension reloads if onboarding has been completed. | ||
| +This patch is part of a temporary fix that will be reverted soon to make way for a more permanent solution. https://github.com/MetaMask/metamask-extension/pull/23005 | ||
| +You can see the changes before compilation on this branch: https://github.com/MetaMask/core/compare/pnf/ext-23622-review?expand=1 | ||
| \ No newline at end of file | ||
| diff --git a/dist/NetworkController.cjs b/dist/NetworkController.cjs | ||
| index cc9793f576eb39a51ab141b7d03de57cf99e5570..c573b5134d40f522217a6ab6df129040d02e9660 100644 | ||
| --- a/dist/NetworkController.cjs | ||
| +++ b/dist/NetworkController.cjs | ||
| @@ -422,7 +422,6 @@ class NetworkController extends base_controller_1.BaseController { | ||
| */ | ||
| async initializeProvider() { | ||
| __classPrivateFieldGet(this, _NetworkController_instances, "m", _NetworkController_applyNetworkSelection).call(this, this.state.selectedNetworkClientId); | ||
| - await this.lookupNetwork(); | ||
| } | ||
| /** | ||
| * Refreshes the network meta with EIP-1559 support and the network status | ||
| diff --git a/dist/NetworkController.mjs b/dist/NetworkController.mjs | ||
| index 806f32edeffaad9f7eb1cafa4184368ec95f63e7..9268947cbed4bf717729ca6ac8ea83a8b91b6e8a 100644 | ||
| --- a/dist/NetworkController.mjs | ||
| +++ b/dist/NetworkController.mjs | ||
| @@ -397,7 +397,6 @@ export class NetworkController extends BaseController { | ||
| */ | ||
| async initializeProvider() { | ||
| __classPrivateFieldGet(this, _NetworkController_instances, "m", _NetworkController_applyNetworkSelection).call(this, this.state.selectedNetworkClientId); | ||
| - await this.lookupNetwork(); | ||
| } | ||
| /** | ||
| * Refreshes the network meta with EIP-1559 support and the network status |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.