Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [POM] fix change language flaky tests and migrate tests to Page Object Model #28777

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Nov 27, 2024

Description

  • Fix change language flaky tests. There are multiple reasons for the flakiness, including taking actions during the loading spinner and excessive misuse of refresh page
  • Migrate change language e2e tests to Page Object Model
  • Created base pages for advanced settings page and general settings page
  • For some special language-related locators, as they are only used in this specific test, I didn't migrate them to POM methods.

Open in GitHub Codespaces

Related issues

Fixes:#27904 #28698 #27390

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue self-assigned this Nov 27, 2024
@chloeYue chloeYue requested a review from a team as a code owner November 27, 2024 16:24
@chloeYue chloeYue marked this pull request as draft November 27, 2024 16:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title test: fix tests test: fix change language flaky tests and migrate tests to Page Object Model Nov 28, 2024
@chloeYue chloeYue changed the title test: fix change language flaky tests and migrate tests to Page Object Model test: [POM] fix change language flaky tests and migrate tests to Page Object Model Nov 28, 2024
@chloeYue chloeYue marked this pull request as ready for review November 28, 2024 09:57
@metamaskbot
Copy link
Collaborator

Builds ready [8041302]
Page Load Metrics (2153 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint40824501987547263
domContentLoaded18282439212717986
load18582454215317986
domInteractive29131502311
backgroundConnect880282210
firstReactRender1796382512
getState27103782211
initialActions01000
loadScripts13571885162915474
setupStore75414136
uiStartup21062922248820297
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@itsyoboieltr itsyoboieltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@seaona seaona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chloeYue chloeYue added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit 5e52a7d Nov 29, 2024
99 checks passed
@chloeYue chloeYue deleted the fix-change-language-tests branch November 29, 2024 11:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants