Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Settings - general tab @no-mmi validate \"Magyar\" l..." flaky tests #27390

Closed
hjetpoluru opened this issue Sep 25, 2024 · 1 comment
Closed

Fix "Settings - general tab @no-mmi validate \"Magyar\" l..." flaky tests #27390

hjetpoluru opened this issue Sep 25, 2024 · 1 comment
Assignees
@chloeYue
Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug

Comments

@hjetpoluru
Copy link
Contributor

hjetpoluru commented Sep 25, 2024 •
edited
Loading

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102141/workflows/ebf4465e-b8ee-4bc1-8bd1-0b71a56c148b/jobs/3805055/tests

Build - Webpack
Browser - Chrome
Test Scenario - Settings - general tab @no-mmi validate "Magyar" language change on hypertext
Test Path - /test/e2e/tests/settings/change-language.spec.ts

Error: failed to fetch hu locale because of TypeError: Failed to fetch
  (Ran on CircleCI Node 5 of 20, Job test-e2e-chrome-webpack)
    at withFixtures (test/e2e/helpers.js:229:13)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Context.<anonymous> (test/e2e/tests/settings/change-language.spec.ts:2:6290)

image

Console log

-----Received an error from Chrome-----
failed to fetch hu locale because of TypeError: Failed to fetch
----------End of Chrome error----------
@hjetpoluru hjetpoluru added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform flaky tests labels Sep 25, 2024
@hjetpoluru hjetpoluru self-assigned this Sep 25, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 25, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 25, 2024
This was referenced Sep 27, 2024
Open
Closed
@hjetpoluru hjetpoluru mentioned this issue Oct 4, 2024
Closed
7 tasks
@chloeYue chloeYue assigned chloeYue and unassigned hjetpoluru Nov 28, 2024
@chloeYue chloeYue mentioned this issue Nov 28, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 29, 2024
@chloeYue
test: [POM] fix change language flaky tests and migrate tests to Page…
5e52a7d 
… Object Model (#28777)

## **Description**

- Fix change language flaky tests. There are multiple reasons for the
flakiness, including taking actions during the loading spinner and
excessive misuse of refresh page
- Migrate change language e2e tests to Page Object Model
- Created base pages for advanced settings page and general settings
page
- For some special language-related locators, as they are only used in
this specific test, I didn't migrate them to POM methods.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27155?quickstart=1)

## **Related issues**

Fixes:#27904
#28698
#27390

## **Manual testing steps**
Check code readability, make sure tests pass.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@chloeYue
Copy link
Contributor

Fixed by PR #28777

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 29, 2024
@chloeYue chloeYue mentioned this issue Dec 2, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloeYue chloeYue

Labels
flaky tests Sev2-normal Normal severity; minor loss of service or inconvenience. team-extension-platform type-bug
Projects
Bugs by severity
Archived in project
Bugs by team
Status: Fixed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloeYue @hjetpoluru