Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace AvatarAccount with Identicon #28645

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Nov 22, 2024

Description

This PR fixes icon issue on confirmations mentioned on #28609

Open in GitHub Codespaces

Related issues

Fixes: #28609

Manual testing steps

  1. Go to settings - select Blockies icons
  2. Trigger a signature or contract interaction
  3. See the addresses there are displayed in Blockies
  4. Go to settings - select JazzIcons
  5. Trigger a signature or contract interaction
  6. See the addresses there are displayed in JazzIcons

Screenshots/Recordings

Before

before

After

after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [95fb76a]
Page Load Metrics (1785 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48820501722305146
domContentLoaded16332034175410751
load16442059178511756
domInteractive15119372412
backgroundConnect10109322512
firstReactRender492931286632
getState484222311
initialActions00000
loadScripts11751565128710249
setupStore667172010
uiStartup18422474204618890
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -121 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@OGPoyraz OGPoyraz enabled auto-merge November 25, 2024 11:42
@metamaskbot
Copy link
Collaborator

Builds ready [3fbb477]
Page Load Metrics (2359 ± 320 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint222395518941125540
domContentLoaded166337782322641308
load167239262359666320
domInteractive24184674321
backgroundConnect9193454923
firstReactRender863371425828
getState4172293818
initialActions00000
loadScripts118028101731512246
setupStore57218199
uiStartup187544102673791380
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -121 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit e3eab5c Dec 2, 2024
75 checks passed
@OGPoyraz OGPoyraz deleted the 28609-bug-confirmations-address-icons-are-displayed-as-jazzicons-in-signaturestransactions-despite-having-blockies-option-selected branch December 2, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.10.0 Issue or pull request that will be included in release 12.10.0 team-confirmations Push issues to confirmations team
Projects
None yet
4 participants