[Bug]: Confirmations - Address icons are displayed as JazzIcons in Signatures/Transactions despite having Blockies option selected #28609
Assignees
Labels
regression-prod-12.6.2
Regression bug that was found in production in release 12.6.2
release-12.10.0
Issue or pull request that will be included in release 12.10.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-confirmations
Push issues to confirmations team
type-bug
Comments
seaona
added
type-bug
Sev2-normal
metamaskbot
added
the
regression-prod-12.6.2
|
possibly related to recent asset team changes |
|
Hey @seaona ! jazzicon.-.blockie.mov |
|
okay so I think this only happens if we already have the icon loaded (not the question mark ?), meaning, this would happen with Nicknames disabled from Experimental settings. |
7 tasks
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 2, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes icon issue on confirmations mentioned on #28609 [](https://codespaces.new/MetaMask/metamask-extension/pull/28645?quickstart=1) ## **Related issues** Fixes: #28609 ## **Manual testing steps** 1. Go to settings - select Blockies icons 2. Trigger a signature or contract interaction 3. See the addresses there are displayed in Blockies 4. Go to settings - select JazzIcons 5. Trigger a signature or contract interaction 6. See the addresses there are displayed in JazzIcons ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.10.0
](https://codespaces.new/MetaMask/metamask-extension/pull/28645?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Address icons are displayed as JazzIcons in Signatures/Transactions despite having Blockies option selected
Expected behavior
No response
Screenshots/Recordings
See how the Account icon is displayed in Blockies (Expected) but the addresses inside the Confirmation Signature/Transaction are displayed in JAzzicons
Steps to reproduce
Error messages or log output
No response
Detection stage
In production (default)
Version
12.6.2
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: