-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gas limit estimation #28327
Merged
Merged
fix: gas limit estimation #28327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gas estimation on Base, BNB, and OpBNB networks performs reliably, with no failures observed: testDapp.movnftPrompt.mov |
digiwand
previously approved these changes
Nov 7, 2024
Builds ready [0b4dc4b]
Page Load Metrics (1683 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
approved these changes
Nov 8, 2024
pedronfigueiredo
approved these changes
Nov 8, 2024
jpuri
approved these changes
Nov 8, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 8, 2024
vpintorico
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Nov 21, 2024
vpintorico
added
release-12.6.1
and removed
release-12.6.0
Issue or pull request that will be included in release 12.6.0
release-12.8.0
Issue or pull request that will be included in release 12.8.0
labels
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade transaction controller to fix gas limit estimation on specific networks.
Related issues
Fixes: #28307 #28175
Manual testing steps
See issue.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist