Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gas limit estimation #28327

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 6, 2024

Description

Upgrade transaction controller to fix gas limit estimation on specific networks.

Related issues

Fixes: #28307 #28175

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 6, 2024 14:43
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 6, 2024
@sleepytanya
Copy link
Contributor

Gas estimation on Base, BNB, and OpBNB networks performs reliably, with no failures observed:

testDapp.mov
nftPrompt.mov

digiwand
digiwand previously approved these changes Nov 7, 2024
@sleepytanya
Copy link
Contributor

@matthewwalsh0

Accounts without balance - no errors:

Screenshot 2024-11-07 at 12 52 59 Screenshot 2024-11-07 at 12 52 30

@metamaskbot
Copy link
Collaborator

Builds ready [0b4dc4b]
Page Load Metrics (1683 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15462257168815775
domContentLoaded15342038165611957
load15492129168313465
domInteractive268243157
backgroundConnect898282512
firstReactRender43188873015
getState495152211
initialActions01000
loadScripts11091524121810048
setupStore106122189
uiStartup16942453187616579
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 457 Bytes (0.01%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit 04dd7d3 Nov 8, 2024
76 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/28307-gas-limit-estimation-base branch November 8, 2024 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 8, 2024
@vpintorico vpintorico added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Nov 21, 2024
@vpintorico vpintorico added release-12.6.1 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.6.1 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Spike in gas estimation failures on Base, BNB and OpBNB
8 participants