[Bug]: Spike in gas estimation failures on Base, BNB and OpBNB #28307
Assignees
Labels
regression-prod-12.5.1
Regression bug that was found in production in release 12.5.1
release-12.6.1
Sev1-high
High severity; partial loss of service with severe impact upon users, with no workaround.
team-confirmations
Push issues to confirmations team
type-bug
Comments
bschorchit
added
type-bug
Sev1-high
metamaskbot
added
the
regression-prod-12.5.1
This was referenced Nov 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 8, 2024
## **Description** Upgrade transaction controller to fix gas limit estimation on specific networks. ## **Related issues** Fixes: #28307 #28175 ## **Manual testing steps** See issue. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.8.0
matthewwalsh0
added a commit
that referenced
this issue
Nov 11, 2024
Upgrade transaction controller to fix gas limit estimation on specific networks. Fixes: #28307 #28175 See issue. - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Hi all, thanks for quick fix. Do you perhaps know when fix for this will be released (approximately)? |
vpintorico
removed
the
release-12.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We're seeing a spike in gas estimation failures on Base, BNB and OpBNB that started with v12.5.1 on October 31st.
Metrics suggests it's happening mainly for contract interactions but also for simple sends.
Relevant mixpanel dashboards:
Labeling as a sev1 until we understand the issue better.
Expected behavior
No spike in gas estimation failures
Screenshots/Recordings
Steps to reproduce
or
I could not repro the gas estimation failure for the wallet initiated send flow
Error messages or log output
No response
Detection stage
In production (default)
Version
12.5.1
Build type
None
Browser
Brave
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: