Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust spacing of quote rate in swaps #28016

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

martahj
Copy link
Contributor

@martahj martahj commented Oct 22, 2024

Description

The PR to remove the legacy swaps code inadvertently caused a misalignment of the quote rate. This PR re-aligns it to be where it is expected.

Open in GitHub Codespaces

Manual testing steps

  1. Start a swap
  2. Notice that the quote rate is back on one line and the value is left-aligned

Screenshots/Recordings

Before

Screenshot 2024-10-11 at 11 32 09 AM

After

Screenshot 2024-10-22 at 12 13 50 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -263,7 +263,7 @@
}

&__exchange-rate-display {
color: var(--color-text-alternative);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value was getting overwritten in a child component so I've removed it

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 22, 2024
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and work fine now

@martahj martahj marked this pull request as ready for review October 22, 2024 19:27
@martahj martahj requested a review from a team as a code owner October 22, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants