Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused swaps code #27679

Merged
merged 8 commits into from
Oct 15, 2024
Merged

chore: remove unused swaps code #27679

merged 8 commits into from
Oct 15, 2024

Conversation

martahj
Copy link
Contributor

@martahj martahj commented Oct 7, 2024

Description

Removed code which is no longer needed because we are moving forward with the swaps redesign.

Open in GitHub Codespaces

Manual testing steps

Test Swaps flows and confirm no regresions.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 7, 2024
@martahj martahj changed the title Remove unused code chore: remove unused swaps code Oct 7, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5328384]
Page Load Metrics (2221 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint173628812223282135
domContentLoaded173027252185266128
load173529212221293141
domInteractive30147602914
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -83.57 KiB (-1.09%)
  • common: -3.31 KiB (-0.04%)

@martahj martahj added the needs-qa Label will automate into QA workspace label Oct 8, 2024
@martahj martahj marked this pull request as ready for review October 8, 2024 18:36
@martahj martahj requested review from a team and kumavis as code owners October 8, 2024 18:36
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HowardBraham HowardBraham added this pull request to the merge queue Oct 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [fda3ee0]
Page Load Metrics (1788 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22721951568526252
domContentLoaded15582139176115876
load16002180178816077
domInteractive21173503617
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -83.57 KiB (-1.08%)
  • common: -3.31 KiB (-0.04%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [a8e6bd9]
Page Load Metrics (2112 ± 148 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25628951535841404
domContentLoaded163628122077305146
load166429002112309148
domInteractive3197552010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -83.57 KiB (-1.08%)
  • common: -3.31 KiB (-0.04%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@HowardBraham HowardBraham added this pull request to the merge queue Oct 12, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [81d8db1]
Page Load Metrics (1850 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38120881700447215
domContentLoaded16132078182012459
load16252089185013264
domInteractive198445189
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -83.57 KiB (-1.08%)
  • common: -3.31 KiB (-0.04%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@HowardBraham HowardBraham removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 15, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit a770169 Oct 15, 2024
76 of 79 checks passed
@HowardBraham HowardBraham deleted the remove-unused-code branch October 15, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@github-actions github-actions bot removed the needs-qa Label will automate into QA workspace label Oct 15, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-swaps release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants