-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Permit Simulation should include decimals in fiat calculation and show tooltip if shortened #26523
fix: Permit Simulation should include decimals in fiat calculation and show tooltip if shortened #26523
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Builds ready [07a02f1]
Page Load Metrics (89 ± 11 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26523 +/- ##
===========================================
- Coverage 69.96% 69.96% -0.00%
===========================================
Files 1405 1405
Lines 48996 49000 +4
Branches 13697 13699 +2
===========================================
+ Hits 34280 34282 +2
- Misses 14716 14718 +2 ☔ View full report in Codecov by Sentry. |
Description
Related issues
Fixes: #26520
Manual testing steps
to test lengthier value:
yarn storybook
Screenshots/Recordings
Before
After
After with tooltip showing on lengthy fiat value
Pre-merge author checklist
Pre-merge reviewer checklist