Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Permit Simulation Fiat value should take into account token decimals and show tooltip if ellipsis is shown #26520

Closed
digiwand opened this issue Aug 19, 2024 · 0 comments · Fixed by #26523
Closed

[Bug]: Permit Simulation Fiat value should take into account token decimals and show tooltip if ellipsis is shown #26520

digiwand opened this issue Aug 19, 2024 · 0 comments · Fixed by #26523
Assignees
@digiwand
Labels
regression-prod-12.1.0 Regression bug that was found in production in release 12.1.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 release-blocker This bug is blocking the next release team-confirmations Push issues to confirmations team type-bug

Comments

@digiwand
Copy link
Contributor

digiwand commented Aug 19, 2024 •
edited
Loading

Describe the bug

Blocker for v12.1.0 and will be cherry-picked after merged.

In Signature Redesign, we made an improvement by applying token decimals to the values.

The fiat values shown in the simulation do not appear to calculate with the decimals in mind.

We should apply token decimals onto the fiat calculation.

  1. We also introduced ellipsis for lengthy fiat values. We should display a tooltip when this occurs

Expected behavior

No response

Screenshots/Recordings

Current:

Steps to reproduce

  1. Go to test dapp
  2. Set network to Ethereum Mainnet
  3. Trigger Malicious Permit
  4. Observe USDC is not close in value to fiat value

Error messages or log output

No response

Detection stage

In production (default)

Version

12.1.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Aug 19, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Aug 19, 2024
@digiwand digiwand added release-blocker This bug is blocking the next release release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Aug 19, 2024
@metamaskbot metamaskbot added the regression-prod-12.1.0 Regression bug that was found in production in release 12.1.0 label Aug 19, 2024
@digiwand digiwand added regression-RC-12.1.0 and removed regression-prod-12.1.0 Regression bug that was found in production in release 12.1.0 labels Aug 19, 2024
@alfeng6 alfeng6 added the team-confirmations Push issues to confirmations team label Aug 19, 2024
@digiwand digiwand mentioned this issue Aug 19, 2024
Merged
7 tasks
@metamaskbot metamaskbot added regression-prod-12.1.0 Regression bug that was found in production in release 12.1.0 and removed regression-RC-12.1.0 labels Aug 19, 2024
@digiwand digiwand changed the title [Bug]: Permit Simulation Fiat value should take into account token decimals [Bug]: Permit Simulation Fiat value should take into account token decimals and show tooltip if ellipsis is shown Aug 20, 2024
@digiwand digiwand self-assigned this Aug 20, 2024
@danjm danjm closed this as completed in fc3da74 Aug 20, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Aug 20, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Aug 20, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 20, 2024
@digiwand digiwand removed the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digiwand digiwand

Labels
regression-prod-12.1.0 Regression bug that was found in production in release 12.1.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 release-blocker This bug is blocking the next release team-confirmations Push issues to confirmations team type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
3 participants
@alfeng6 @digiwand @metamaskbot