-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add migration 120.4 to delete obsolete currency controller state #26383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
changed the title
Add migration 120.4 to delete obsolete currency controller state
fix: Add migration 120.4 to delete obsolete currency controller state
Aug 13, 2024
Gudahtt
reviewed
Aug 13, 2024
Co-authored-by: Mark Stacey <[email protected]>
danjm
commented
Aug 13, 2024
Quality Gate passedIssues Measures |
Gudahtt
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
digiwand
approved these changes
Aug 13, 2024
metamaskbot
added
the
release-12.4.0
Issue or pull request that will be included in release 12.4.0
label
Aug 13, 2024
Builds ready [03f30c3]
Page Load Metrics (418 ± 345 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
added
release-12.3.0
Issue or pull request that will be included in release 12.3.0
and removed
release-12.4.0
Issue or pull request that will be included in release 12.4.0
labels
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.3.0
Issue or pull request that will be included in release 12.3.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are seeing the following sorts of errors in production, as reported by sentry, in v12.0.2:
No metadata found for 'conversionDate'
No metadata found for 'usdConversionRate'
No metadata found for 'nativeCurrency'
No metadata found for 'conversionRate'
Example issue: https://metamask.sentry.io/issues/5682684113/events/b8006eebb65749f883e907242e52215b/?project=273505&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D+No+metadata+release%3A12.0.1&referrer=previous-event&statsPeriod=14d&stream_index=1
The
CurrencyRateController
stopped using six such properties with MetaMask/core#1805, which was brought into the extension with #21549, however, there was not a state migration to delete those properties at the timeThis PR adds migrations to delete those obsolete properties
Related issues
Fixes: #26356
Manual testing steps
To observe the error using steps that mimic users in production
master
branchIf you repeat those steps, but in step two build from this branch instead of the
master
branch, the errors will not occurFor a faster manual test of this PR, create a local development build of this branch and then run this script in the service worker console:
There should be no errors like
No metadata found for 'conversionRate'
(but if you do the same on develop or master, those errors should be present)Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist