bump `@metamask/assets-controllers` to `^18.0.0` #21549

jiexi · 2023-10-25T22:45:17Z

Description

Bumps @metamask/assets-controllers to v18.0.0 which includes breaking changes for the CurrencyRateController. Notably the structure of the state has changed significantly. Part of making the state change so drastic (as opposed to making the refactor towards Multichain be as small/incremental as possible), is that the usage of pendingNativeCurrency, pendingCurrentCurrency, and how the controller handles state change in general causes unexpected behavior with concurrent updates. The update to CurrencyRateController also solves this issue.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1025
Related: MetaMask/core#1687

Manual testing steps

Nothing should change for the end user.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ontroller

github-actions · 2023-10-25T22:45:33Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…ontroller

socket-security · 2023-11-02T17:35:33Z

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/assets-controllers	16.0.0...18.0.0	None	`+0/-2`	678 kB	metamaskbot

🚮 Removed packages: @metamask/[email protected]

…0' into jl/bump-network-controller-15.1.0

…ontroller

…tichain-v1-currency-rate-controller

socket-security · 2023-11-03T17:55:17Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

## **Description** * Bump `@metamask/network-controller` to `15.1.0` * Replace `eth-query` with `@metamask/eth-query` * Bump `@metamask/eth-query` to `3.0.1` Needed for bumping `@metamask/assets-controller` to 18.0.0 from 16 ## **Related issues** See: #21549 ## **Manual testing steps** Nothing should change for the end user ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>

…ontroller

jiexi · 2023-11-06T22:30:35Z

@metamaskbot update-policies

metamaskbot · 2023-11-06T22:41:57Z

Policies updated

…ontroller

codecov · 2023-11-08T19:52:10Z

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f307eb8) 68.40% compared to head (32ac98b) 68.44%.
Report is 2 commits behind head on develop.

Files	Patch %	Lines
app/scripts/metamask-controller.js	72.73%	3 Missing ⚠️
ui/pages/asset/asset.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #21549      +/-   ##
===========================================
+ Coverage    68.40%   68.44%   +0.04%     
===========================================
  Files         1046     1046              
  Lines        41689    41647      -42     
  Branches     11112    11101      -11     
===========================================
- Hits         28514    28503      -11     
+ Misses       13175    13144      -31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-11-08T20:02:09Z

Builds ready [86bba7b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (562 ± 279 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	121	99	8	4
		domContentLoaded	70	112	87	12	6
		load	82	1428	562	581	279
		domInteractive	70	112	87	12	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -4.33 KiB (-0.11%)
ui: 307 Bytes (0.00%)
common: 1.12 KiB (0.02%)

app/scripts/lib/getObjStructure.js

adonesky1 · 2023-11-10T00:11:15Z

app/scripts/metamask-controller.js

-          await this.currencyRateController.setNativeCurrency(ticker);
+          if (
+            this.preferencesController.store.getState().useCurrencyRateCheck
+          ) {
+            await this.currencyRateController.stopAllPolling();
+            this.currencyRateController.startPollingByNetworkClientId(
+              this.networkController.state.selectedNetworkClientId,
+            );
+          }


Is this changing the behavior here? Previously calling setNativeCurrency didn't start polling it just updated the exchangerate once?

not sure why we wouldn't want to poll here but I'm not seeing that we did before?

It does not as we guard starting the poll with a call to this.preferencesController.store.getState().useCurrencyRateCheck

right but previously we didn't start polling regardless of whether or not the useCurrencyRateCheck was set to true? We just checked once? Again I feel like we would want to stop/start polling here but it does seems like the behavior would change given your changes? But might be missing something

Right, previously we did not start/stop polling for the CurrencyRateController on networkDidChange from MetaMaskController. That's because previously, it was possible to tell the CurrencyRateController that you wanted to "queue up" an update for the exchange rates for XYZ native currency and let the controller poll for it on its own time whenever that next poll iteration would happen. Now it's not possible to tell the CurrencyRateController to "queue up" a nativeCurrency. It's either polling or it isn't. Because of that, we need to keep track of useCurrencyRateCheck outside of the CurrencyRateController and handling the starting/stopping of polling ourselves

why not have the CurrencyRateController's messenger subscribe to NetworkController changes and do this start/stop polling in the controller itself as we do with most other controllers?

I suppose it could. That would require adding a guard to check useCurrencyRateCheck on each polling loop as a way to pause polling as opposed to just stopping the polling itself directly. That would mean if useCurrencyRateCheck is set to false, and i call currencyRateController.startPollingByNetworkClientId('123'), then the polling would be active, but will always exit early until useCurrencyRateCheck is set to true.

Does this seem to be more inline with how you were thinking we should approach this?

Could we not check useCurrencyRateCheck in the frontend an only call startPollingByNetworkClientId if its true?

Oh sorry that didn't make sense in this context.

Well couldn't we check useCurrencyRateCheck in the handler for networkStateChange on the CurrencyRateController and only start polling if its true?

I won't block on this. We can leave it as is for now.

ui/ducks/metamask/metamask.js

adonesky1 · 2023-11-10T17:14:32Z

ui/selectors/confirm-transaction.js

@@ -140,8 +141,8 @@ export const use4ByteResolutionSelector = (state) =>
  state.metamask.use4ByteResolution;
 export const currentCurrencySelector = (state) =>
  state.metamask.currentCurrency;
-export const conversionRateSelector = (state) => state.metamask.conversionRate;
-
+export const conversionRateSelector = (state) =>


isn't this a duplicate of the getConversionRate selector in ducks/metamask/metamask.js. I guess there are a bunch of duplicates in here?

adonesky1

Just a few small questions! Otherwise LGTM! Also looks like it needs a rebase

…ontroller

jiexi · 2023-11-13T17:51:56Z

@metamaskbot update-policies

metamaskbot · 2023-11-13T18:05:56Z

Policies updated

metamaskbot · 2023-11-13T18:35:47Z

Builds ready [d550ce2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (733 ± 286 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	131	104	14	7
		domContentLoaded	70	128	94	18	9
		load	82	1468	733	596	286
		domInteractive	70	128	94	18	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -4.33 KiB (-0.11%)
ui: 307 Bytes (0.00%)
common: 1.12 KiB (0.02%)

…ontroller

adonesky1

LGTM!

…ontroller

metamaskbot · 2023-11-13T22:44:30Z

Builds ready [7181ef8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (561 ± 275 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	87	132	107	15	7
		domContentLoaded	75	124	94	14	7
		load	83	1489	561	573	275
		domInteractive	75	124	94	14	7

Bundle size diffs [🚀 Bundle size reduced!]

background: -4.33 KiB (-0.11%)
ui: 307 Bytes (0.00%)
common: 1.12 KiB (0.02%)

…ontroller

metamaskbot · 2023-11-14T17:08:58Z

Builds ready [32ac98b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (641 ± 296 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	130	105	10	5
		domContentLoaded	72	121	94	14	6
		load	84	1658	641	617	296
		domInteractive	72	121	94	14	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -4.33 KiB (-0.11%)
ui: 307 Bytes (0.00%)
common: 1.12 KiB (0.02%)

## **Description** Cryptocompare reported a spike in API requests. This is the result of incorrectly starting CurrencyRateController polling on MetaMask extension background startup. This PR fixes the issue by removing the logic that was starting CurrencyRateController polling in the constructor. ## **Related issues** Fixes: #21549 ## **Manual testing steps** 1. Open network debug on background.html 2. Restart extension 3. No cryptocompare requests should be seen 4. Open wallet UI 5. One cryptocompare request should be seen 6. Wait 3mins 7. Another cryptocompare request should be seen 8. Close UI 9. Wait 3mins 10. No additional cryptocompare requests should be seen ## **Screenshots/Recordings**  ### **Before** Note the requests made before the UI is open, but that they are stopped after UI is opened then closed for the first time. https://github.com/MetaMask/metamask-extension/assets/918701/c66eabd0-363b-467a-87e3-5628daa95395 ### **After** https://github.com/MetaMask/metamask-extension/assets/918701/3676fa9d-4b6f-4c4d-941d-eac7b0ab7194 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…#22326) (#22328) ## **Description** Cryptocompare reported a spike in API requests. This is the result of incorrectly starting CurrencyRateController polling on MetaMask extension background startup. This PR fixes the issue by removing the logic that was starting CurrencyRateController polling in the constructor. ## **Related issues** Fixes: #21549 ## **Manual testing steps** 1. Open network debug on background.html 2. Restart extension 3. No cryptocompare requests should be seen 4. Open wallet UI 5. One cryptocompare request should be seen 6. Wait 3mins 7. Another cryptocompare request should be seen 8. Close UI 9. Wait 3mins 10. No additional cryptocompare requests should be seen ## **Screenshots/Recordings**  ### **Before** Note the requests made before the UI is open, but that they are stopped after UI is opened then closed for the first time. https://github.com/MetaMask/metamask-extension/assets/918701/c66eabd0-363b-467a-87e3-5628daa95395 ### **After** https://github.com/MetaMask/metamask-extension/assets/918701/3676fa9d-4b6f-4c4d-941d-eac7b0ab7194 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. ## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jiexi added 7 commits October 11, 2023 14:21

WIP

53df8b1

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

88d8fbb

…ontroller

Fix currencyRateController MMC state typo

188af73

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

12e6444

…ontroller

preview build

64f043e

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

fa740a9

…ontroller

WIP

4d6c72f

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

884d25f

…ontroller

Bump network-controller 15.1.0

a322f8e

jiexi mentioned this pull request Nov 2, 2023

Bump @metamask/network-controller to 15.1.0 #21668

Merged

13 tasks

metamaskbot and others added 8 commits November 2, 2023 18:15

Update LavaMoat policies

2e34e87

WIP

5c759a3

Fix type

af54997

Merge remote-tracking branch 'origin/jl/bump-network-controller-15.1.…

95d4d8f

…0' into jl/bump-network-controller-15.1.0

Bump eth-query to 3.0.1

1a7b2d9

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

f56276a

…ontroller

Merge branch 'jl/bump-network-controller-15.1.0' into jl/mmp-1025/mul…

16a876e

…tichain-v1-currency-rate-controller

dedupe

68a23c8

jiexi added the team-wallet-api-platform label Nov 2, 2023

Fix specs

2d3f07a

jiexi added 2 commits November 6, 2023 14:10

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

830a349

…ontroller

lint

629203b

Update LavaMoat policies

a706413

Fix many specs

52d51cd

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

86bba7b

…ontroller

adonesky1 reviewed Nov 10, 2023

View reviewed changes

app/scripts/lib/getObjStructure.js Show resolved Hide resolved

adonesky1 reviewed Nov 10, 2023

View reviewed changes

ui/ducks/metamask/metamask.js Show resolved Hide resolved

adonesky1 reviewed Nov 10, 2023

View reviewed changes

ui/ducks/metamask/metamask.js Show resolved Hide resolved

adonesky1 reviewed Nov 10, 2023

View reviewed changes

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

c82b4da

…ontroller

Update LavaMoat policies

d550ce2

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

7181ef8

…ontroller

adonesky1 approved these changes Nov 13, 2023

View reviewed changes

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

0c45fcd

…ontroller

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

eddb59b

…ontroller

shanejonas approved these changes Nov 14, 2023

View reviewed changes

Merge branch 'develop' into jl/mmp-1025/multichain-v1-currency-rate-c…

32ac98b

…ontroller

jiexi merged commit 82ea5a0 into develop Nov 14, 2023
65 checks passed

jiexi deleted the jl/mmp-1025/multichain-v1-currency-rate-controller branch November 14, 2023 17:18

github-actions bot locked and limited conversation to collaborators Nov 14, 2023

metamaskbot added the release-11.7.0 Issue or pull request that will be included in release 11.7.0 label Nov 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump `@metamask/assets-controllers` to `^18.0.0` #21549

bump `@metamask/assets-controllers` to `^18.0.0` #21549

jiexi commented Oct 25, 2023 •

edited

Loading

github-actions bot commented Oct 25, 2023

socket-security bot commented Nov 2, 2023 •

edited

Loading

socket-security bot commented Nov 3, 2023 •

edited

Loading

jiexi commented Nov 6, 2023

metamaskbot commented Nov 6, 2023

codecov bot commented Nov 8, 2023 •

edited

Loading

metamaskbot commented Nov 8, 2023

adonesky1 Nov 10, 2023

adonesky1 Nov 10, 2023

jiexi Nov 13, 2023

adonesky1 Nov 13, 2023 •

edited

Loading

jiexi Nov 13, 2023

jiexi Nov 13, 2023

adonesky1 Nov 13, 2023

adonesky1 Nov 13, 2023

adonesky1 Nov 13, 2023

adonesky1 Nov 13, 2023

adonesky1 Nov 10, 2023

adonesky1 left a comment

jiexi commented Nov 13, 2023

metamaskbot commented Nov 13, 2023

metamaskbot commented Nov 13, 2023

adonesky1 left a comment

metamaskbot commented Nov 13, 2023

metamaskbot commented Nov 14, 2023

bump @metamask/assets-controllers to ^18.0.0 #21549

bump @metamask/assets-controllers to ^18.0.0 #21549

Conversation

jiexi commented Oct 25, 2023 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 25, 2023

socket-security bot commented Nov 2, 2023 • edited Loading

socket-security bot commented Nov 3, 2023 • edited Loading

jiexi commented Nov 6, 2023

metamaskbot commented Nov 6, 2023

codecov bot commented Nov 8, 2023 • edited Loading

Codecov Report

metamaskbot commented Nov 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adonesky1 Nov 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adonesky1 left a comment

Choose a reason for hiding this comment

jiexi commented Nov 13, 2023

metamaskbot commented Nov 13, 2023

metamaskbot commented Nov 13, 2023

adonesky1 left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 13, 2023

metamaskbot commented Nov 14, 2023

bump `@metamask/assets-controllers` to `^18.0.0` #21549

bump `@metamask/assets-controllers` to `^18.0.0` #21549

jiexi commented Oct 25, 2023 •

edited

Loading

socket-security bot commented Nov 2, 2023 •

edited

Loading

socket-security bot commented Nov 3, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading

adonesky1 Nov 13, 2023 •

edited

Loading