feat: Move ENABLE_CONFIRMATION_REDESIGN feature flag to the developer settings page #25520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -91,6 +96,13 @@ const DeveloperOptionsTab = () => { | |||
| setIsServiceWorkerKeptAlive(value); | |||
| }; | |||
|
|
|||
| const handleToggleEnableConfirmationsRedesign = async ( | |||
There was a problem hiding this comment.
perhaps setConfirmationsRedesignEnabled as we're setting instead of toggling?
There was a problem hiding this comment.
we toggle on the UI, happy to rename if necessary
There was a problem hiding this comment.
This is totally optional but the reason I think set is a better fit here is that toggle functions are usually associated with flipping the value independently of what it is at the moment.
for example
const toggleEnableConfirmationsRedesign = async (): Promise<void> => {
const previousValue = useSelector(isRedesignedConfirmationsFeatureEnabled);
await dispatch(setRedesignedConfirmationsDeveloperEnabled(!previousValue));
await setIsRedesignedConfirmationsFeatureEnabled(!previousValue);
}However, in this case the function is receiving an explicit value as an argument, so it seems to be a set function.
In other words, there is indeed a feature toggle, but the function is not toggling, it's setting.
Builds ready [5736f66]
Page Load Metrics (46 ± 9 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5736f66]
Page Load Metrics (46 ± 9 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25520 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 1401 1402 +1
Lines 49628 49652 +24
Branches 13713 13720 +7
========================================
+ Hits 34577 34594 +17
- Misses 15051 15058 +7 ☔ View full report in Codecov by Sentry. |
Builds ready [f32ec89]
Page Load Metrics (324 ± 293 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ad9e3c2]
Page Load Metrics (172 ± 202 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
test/e2e/tests/confirmations/transactions/contract-interaction-redesign.spec.ts
Show resolved
Hide resolved
pedronfigueiredo
previously approved these changes
Jul 18, 2024
Builds ready [cd543bb]
Page Load Metrics (240 ± 236 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
digiwand
reviewed
Jul 18, 2024
Comment on lines
+1557
to
+1562
| "developerOptionsEnableConfirmationsRedesignDescription": { | ||
| "message": "Enables or disables the confirmations redesign feature currently in development" | ||
| }, | ||
| "developerOptionsEnableConfirmationsRedesignTitle": { | ||
| "message": "Confirmations Redesign" | ||
| }, |
There was a problem hiding this comment.
we can actually remove the locales here. Or I can follow-up to remove them to not block this PR.
It was discussed that we do not need to support i18n in the Developer Options Settings since this is internal
ticket to remove translations:
#24412
digiwand
previously approved these changes
Jul 18, 2024
pnarayanaswamy
dismissed stale reviews from digiwand, matthewwalsh0, and pedronfigueiredo
via
da6a204
pedronfigueiredo
approved these changes
Jul 22, 2024
matthewwalsh0
approved these changes
Jul 22, 2024
|
Builds ready [50b45b5]
Page Load Metrics (135 ± 151 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danjm
approved these changes
Jul 22, 2024
metamaskbot
added
the
release-12.3.0
digiwand
added
release-12.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: #2620
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist