Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace i18n logic with hardcoded strings in the Developer Options Settings Page #24412

Closed
9 tasks
digiwand opened this issue May 7, 2024 · 0 comments · Fixed by #26380
Closed
9 tasks

Replace i18n logic with hardcoded strings in the Developer Options Settings Page #24412

digiwand opened this issue May 7, 2024 · 0 comments · Fixed by #26380
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team

Comments

@digiwand
Copy link
Contributor

digiwand commented May 7, 2024

What is this about?

The Developer Options Settings Page was introduced here #22382

Since this page is used for internal developers, there is no need to translate the text on this page. We should be able to remove the translation dependency and the following key value en translations:

  • announcements
  • developerOptionsServiceWorkerKeepAlive
  • developerOptionsResetStatesAnnouncementsDescription
  • developerOptionsResetStatesOnboarding
  • onboarding
  • resetStates
  • serviceWorkerKeepAlive
  • states

The list above is part of the "do not translate" list provided to our translators (ref https://consensys.slack.com/archives/CTQAGKY5V/p1715031228207729)

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@digiwand digiwand added the team-confirmations Push issues to confirmations team label Aug 13, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 14, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants