-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 25457 firefox extension not work for trezor connect #25487
Conversation
…e to firefox not support USB api. if usb is undefined detected, system will fallback to use trezor bridge.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25487 +/- ##
========================================
Coverage 65.19% 65.19%
========================================
Files 1405 1405
Lines 55571 55571
Branches 14592 14592
========================================
Hits 36229 36229
Misses 19342 19342 ☔ View full report in Codecov by Sentry. |
Builds ready [e0ee6aa]
Page Load Metrics (50 ± 4 ms)
Bundle size diffs
|
… in select-hardware.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Builds ready [93cfd69]
Page Load Metrics (53 ± 4 ms)
Bundle size diffs
|
Missing release label release-11.16.15 on PR. Adding release label release-11.16.15 on PR and removing other release labels(release-12.1.0), as PR was cherry-picked in branch 11.16.15. |
#25457 Because firefox doesn't support usb api, which cause the
window.navigator.usb
is undefined in firefox, which break the trezor connection.This PR will check whether window.navigator.usb is undefined or not. if yes, then select-hardware will fall back to use trezor bridge to connect.
Description
Related issues
Fixes: #25457
Manual testing steps
metamask
in firefoxaccount drop down
in home page and then selectAdd Account and hardware wallet
trezor
in hardware select screen.accounts
from trezor.Screenshots/Recordings
Before
After
Screen.Recording.2024-06-24.at.15.59.20.mov
Pre-merge author checklist
Pre-merge reviewer checklist