Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cannot connect Trezor on Firefox on version 11.16.10-11.6.7 or earlier. (After 11.16,0) #25457

Closed
adamvp opened this issue Jun 20, 2024 · 3 comments · Fixed by #25487
Closed

[Bug]: Cannot connect Trezor on Firefox on version 11.16.10-11.6.7 or earlier. (After 11.16,0) #25457

adamvp opened this issue Jun 20, 2024 · 3 comments · Fixed by #25487
Assignees
@dawnseeker8
Labels
external-contributor regression-prod-11.16.10 Regression bug that was found in production in release 11.16.10 release-11.16.15 Issue or pull request that will be included in release 11.16.15 release-12.1.0 Issue or pull request that will be included in release 12.1.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-hardware-wallets type-bug
Milestone
Q2 2024 CET hw

Comments

@adamvp
Copy link

adamvp commented Jun 20, 2024

Describe the bug

"continue" button is inactive

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/home.html#new-account/connect
here

Error messages or log output

Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
SES_UNHANDLED_REJECTION: (TypeError#1) sentry-install.js:1:693
TypeError#1: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
SES_UNHANDLED_REJECTION: (TypeError#2) sentry-install.js:1:693
TypeError#2: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
SES_UNHANDLED_REJECTION: (TypeError#3) sentry-install.js:1:693
TypeError#3: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
SES_UNHANDLED_REJECTION: (TypeError#4) sentry-install.js:1:693
TypeError#4: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
SES_UNHANDLED_REJECTION: (TypeError#5) sentry-install.js:1:693
TypeError#5: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
SES_UNHANDLED_REJECTION: (TypeError#6) sentry-install.js:1:693
TypeError#6: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
SES_UNHANDLED_REJECTION: (TypeError#7) sentry-install.js:1:693
TypeError#7: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
Uncaught (in promise) TypeError: window.navigator.usb is undefined
ui-7.js:1:274106
SES_UNHANDLED_REJECTION: (TypeError#8) sentry-install.js:1:693
TypeError#8: window.navigator.usb is undefined sentry-install.js:1:693
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
m@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1548
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
_@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1691
setupProxy/n/e[t]@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/scripts/sentry-install.js:1:693
k/<@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1837
k@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:1923
j@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2372
P@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2184
C@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:2533
Tr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29575
le@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:115153
jr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30191
Rr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:31148
Cr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:30436
r.unstable_runWithPriority@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:3:15370
Qi@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:46222
se@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:114920
Pr@moz-extension://15f7aa63-94ca-44f4-adfe-add6a14ae297/common-5.js:1:29859
sentry-install.js:1:693

Version

11.16.10

Build type

None

Browser

Firefox

Operating system

Windows

Hardware wallet

Trezor

Additional context

No response

Severity

critical, cannot access funds.
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jun 20, 2024
@metamaskbot metamaskbot added external-contributor regression-prod-11.16.10 Regression bug that was found in production in release 11.16.10 labels Jun 20, 2024
@adamvp adamvp changed the title [Bug]: Cannot connect Trezor on Firefox on version 11.16.10-11.6.7 or earlier. (After 11.12) [Bug]: Cannot connect Trezor on Firefox on version 11.16.10-11.6.7 or earlier. (After 11.16,0) Jun 20, 2024
@adamvp
Copy link
Author

adamvp commented Jun 20, 2024 •
edited
Loading

just downgraded to 11.16.0 and this ver works OK
at least in the part of connecting trezor

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 24, 2024
@dawnseeker8 dawnseeker8 mentioned this issue Jun 24, 2024
Merged
7 tasks
@gauthierpetetin gauthierpetetin added the Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. label Jun 24, 2024
@danjm danjm closed this as completed in f90eed6 Jun 24, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 24, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 24, 2024
danjm added a commit that referenced this issue Jun 24, 2024
@dawnseeker8 @danjm
fix: 25457 firefox extension not work for trezor connect (#25487)
ab3d7f5 
#25457 Because firefox doesn't support usb api, which cause the
`window.navigator.usb` is undefined in firefox, which break the trezor
connection.

This PR will check whether window.navigator.usb is undefined or not. if
yes, then select-hardware will fall back to use trezor bridge to
connect.

## **Description**

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25487?quickstart=1)

## **Related issues**

Fixes: #25457 

## **Manual testing steps**

1. Open `metamask` in firefox
2. select `account drop down` in home page and then select `Add Account
and hardware wallet`
3. select `trezor` in hardware select screen.
4. approve at trezor screen
5. you should be able to select `accounts` from trezor.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**



https://github.com/MetaMask/metamask-extension/assets/7315988/980c6c78-2765-4f97-8781-8250eeec1f9b


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Dan J Miller <[email protected]>
@danjm danjm mentioned this issue Jun 24, 2024
Merged
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 24, 2024
danjm added a commit that referenced this issue Jun 26, 2024
@dawnseeker8 @danjm
fix: 25457 firefox extension not work for trezor connect (#25487)
264838e 
#25457 Because firefox doesn't support usb api, which cause the
`window.navigator.usb` is undefined in firefox, which break the trezor
connection.

This PR will check whether window.navigator.usb is undefined or not. if
yes, then select-hardware will fall back to use trezor bridge to
connect.

## **Description**

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25487?quickstart=1)

## **Related issues**

Fixes: #25457 

## **Manual testing steps**

1. Open `metamask` in firefox
2. select `account drop down` in home page and then select `Add Account
and hardware wallet`
3. select `trezor` in hardware select screen.
4. approve at trezor screen
5. you should be able to select `accounts` from trezor.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**



https://github.com/MetaMask/metamask-extension/assets/7315988/980c6c78-2765-4f97-8781-8250eeec1f9b


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Dan J Miller <[email protected]>
danjm added a commit that referenced this issue Jun 26, 2024
@danjm @dawnseeker8
fix (cherry-pick): 25457 firefox extension not work for trezor connect (
35f5a71 
#25487) (#25494)

Cherry-picks f90eed6 / #25457 into Version-v11.16.15

Co-authored-by: Xiaoming Wang <[email protected]>
@metamaskbot metamaskbot added the release-11.16.15 Issue or pull request that will be included in release 11.16.15 label Jun 26, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.16.15 on issue. Adding release label release-11.16.15 on issue, as issue is linked to PR #25487 which has this release label.

@angelcheung22 angelcheung22 added this to the Q2 2024 CET hw milestone Jul 17, 2024
@benjisclowder
Copy link
Contributor

Collaborative Effort Required for Root Cause Analysis (RCA) on Critical Issues

We are quickly approaching the end of the quarter and we encourage you once again to take some moments and perform RCA on this critical issue. You may do so by answering the questions below:

1. What PR fixed the issue?
2. Can you pinpoint the commit from which the issue originated?
3. Write a short explanation of the technical cause of the bug
4. How could we have avoided merging this bug? What would have had to be different about our code, tests or processes?
4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue?
4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue?
4.3. If your answer to a and b is no, then is there anything at all that you can think of that, if it had been different before this bug was introduced, would have prevented it from being merged?

Please provide your answers as a reply to this comment and tag me as well.

You can read more about the initiative here. Thank you!

Tagging eng. who added the fix: @dawnseeker8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawnseeker8 dawnseeker8

Labels
external-contributor regression-prod-11.16.10 Regression bug that was found in production in release 11.16.10 release-11.16.15 Issue or pull request that will be included in release 11.16.15 release-12.1.0 Issue or pull request that will be included in release 12.1.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-hardware-wallets type-bug
Projects
Bugs by severity
Archived in project
Milestone
Q2 2024 CET hw
Development

Successfully merging a pull request may close this issue.

fix: 25457 firefox extension not work for trezor connect MetaMask/metamask-extension
6 participants
@gauthierpetetin @dawnseeker8 @adamvp @metamaskbot @angelcheung22 @benjisclowder