-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle long nft ids in simulation amount pill #25252
fix: handle long nft ids in simulation amount pill #25252
Conversation
@@ -78,6 +87,7 @@ export const AmountPill: React.FC<{ | |||
position="bottom" | |||
title={tooltipParts.join(' ')} | |||
wrapperStyle={{ minWidth: 0 }} | |||
theme="word-break-all" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately Tooltip
ignores style
property hence this is the only proper solution that I find.
9e9d403
to
0f2adf9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25252 +/- ##
===========================================
- Coverage 64.89% 64.87% -0.02%
===========================================
Files 1382 1382
Lines 54770 54795 +25
Branches 14372 14381 +9
===========================================
+ Hits 35539 35547 +8
- Misses 19231 19248 +17 ☔ View full report in Codecov by Sentry. |
Builds ready [bb43054]
Page Load Metrics (135 ± 185 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/pages/confirmations/components/simulation-details/amount-pill.tsx
Outdated
Show resolved
Hide resolved
ui/pages/confirmations/components/simulation-details/amount-pill.tsx
Outdated
Show resolved
Hide resolved
Builds ready [f9fd048]
Page Load Metrics (55 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This PR aims to fix styling
AmountPill
component used in theSimulationDetails
. When there is a long NFT id given it overflows and shrinks theAssetPill
. If there is a long id given, now we want to shorten it.Also the fixes the tooltip text which is currently overflowing the container.
Related issues
Fixes: #24178
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist