Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Not ellipsing long NFT ID within simulations #24178

Closed
bschorchit opened this issue Apr 22, 2024 · 1 comment · Fixed by #25252
Closed

[Bug]: Not ellipsing long NFT ID within simulations #24178

bschorchit opened this issue Apr 22, 2024 · 1 comment · Fixed by #25252
Assignees
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.14.0 Regression bug that was found in production in release 11.14.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@bschorchit
Copy link

Describe the bug

We show too many numbers for long NFT ids causing the name component to be very small.

Expected behavior

We should show less numbers for long NFT ID within simulations and allow users to see the full id with the tooltip.

Screenshots/Recordings

Screenshot 2024-04-22 at 14 03 10

Steps to reproduce

Go to ENS on Sepolia test network and purchase an ENS name

Error messages or log output

No response

Version

11.14.0

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@bschorchit bschorchit added type-bug team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Apr 22, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 22, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Apr 22, 2024
@bschorchit bschorchit added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Apr 22, 2024
@metamaskbot metamaskbot added the regression-prod-11.14.0 Regression bug that was found in production in release 11.14.0 label Apr 22, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@SayaGT
Copy link

SayaGT commented Apr 25, 2024

Lets truncate the NFT ID and only show first & last 4 characters of the ID. So it would look like + 1 #1234...7890 . We could display the complete ID in the tooltip.

I also noticed the tooltip extends beyond the page making it impossible to see the complete ID. Can we make sure the ID wraps around to keep the tooltip within the page.

@SayaGT SayaGT added the area-design Design bug (previously known as papercuts - ask Hilary for more detail) label Jun 4, 2024
@OGPoyraz OGPoyraz self-assigned this Jun 7, 2024
@OGPoyraz OGPoyraz linked a pull request Jun 12, 2024 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 20, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 20, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.14.0 Regression bug that was found in production in release 11.14.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants