-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hardware wallet e2e test mv3 support #25039
fix: hardware wallet e2e test mv3 support #25039
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Google chrome works, Firefox is broken for some reason. Error msg:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25039 +/- ##
===========================================
- Coverage 65.70% 65.70% -0.00%
===========================================
Files 1369 1369
Lines 54366 54366
Branches 14149 14149
===========================================
- Hits 35718 35717 -1
- Misses 18648 18649 +1 ☔ View full report in Codecov by Sentry. |
LGTM. Merged ! |
Description
This PR removes the skip for the e2e test named
Connects to a Hardware wallet for lattice
. After removing the skip, I also discovered that the test fails, because the case where MV3 is enabled was not handled. This was rectified accordingly.Related issues
Fixes: #24688
Manual testing steps
Screenshots/Recordings
Not applicable, no visual changes.
Pre-merge author checklist
Pre-merge reviewer checklist