Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardware wallet e2e test mv3 support #25039

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: hardware wallet e2e test mv3 support #25039

merged 1 commit into from
Jun 10, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jun 4, 2024

Description

Open in GitHub Codespaces

This PR removes the skip for the e2e test named Connects to a Hardware wallet for lattice. After removing the skip, I also discovered that the test fails, because the case where MV3 is enabled was not handled. This was rectified accordingly.

Related issues

Fixes: #24688

Manual testing steps

  1. yarn test:e2e:single test/e2e/tests/account/import-flow.spec.js

Screenshots/Recordings

Not applicable, no visual changes.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr requested a review from a team as a code owner June 4, 2024 17:07
Copy link
Contributor

github-actions bot commented Jun 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@itsyoboieltr
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@itsyoboieltr
Copy link
Contributor Author

Google chrome works, Firefox is broken for some reason.

Error msg:

    <testcase name="Import flow @no-mmi Connects to a Hardware wallet for lattice" time="25.152" classname="Connects to a Hardware wallet for lattice">
      <failure message="waitUntilXWindowHandles timed out polling window handles" type="Error"><![CDATA[Error: waitUntilXWindowHandles timed out polling window handles
    at Driver.waitUntilXWindowHandles (test/e2e/webdriver/driver.js:798:1)
    at /Users/norbertelter/metamask/metamask-extension/test/e2e/tests/account/import-flow.spec.js:293:32
    at withFixtures (test/e2e/helpers.js:115:9)
    at Context.<anonymous> (test/e2e/tests/account/import-flow.spec.js:321:9)]]></failure>
    </testcase>

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (0dc77eb) to head (c97be31).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25039      +/-   ##
===========================================
- Coverage    65.70%   65.70%   -0.00%     
===========================================
  Files         1369     1369              
  Lines        54366    54366              
  Branches     14149    14149              
===========================================
- Hits         35718    35717       -1     
- Misses       18648    18649       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica DDDDDanica merged commit 0a65a61 into MetaMask:develop Jun 10, 2024
81 checks passed
@DDDDDanica
Copy link
Contributor

LGTM. Merged !

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
@chloeYue chloeYue added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.1.0 Issue or pull request that will be included in release 12.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove skipping MV3 e2e tests for hardware wallet
5 participants